* Re: [PATCH v3 0/5] perf build: libtraceevent, libtracefs feature check with pkg-config [not found] ` <20240712194511.3973899-1-amadio@gentoo.org> @ 2024-07-17 16:27 ` Namhyung Kim 2024-07-17 16:31 ` Steven Rostedt 0 siblings, 1 reply; 3+ messages in thread From: Namhyung Kim @ 2024-07-17 16:27 UTC (permalink / raw) To: Guilherme Amadio, Steven Rostedt Cc: Arnaldo Carvalho de Melo, Ian Rogers, Thorsten Leemhuis, Leo Yan, linux-perf-users, Linux Kernel Mailing List, linux-trace-kernel Hello, On Fri, Jul 12, 2024 at 12:45 PM Guilherme Amadio <amadio@gentoo.org> wrote: > > Hi Namhyung, Arnaldo, > > Here is version 3 of the patchset. I see the change to send output to devnull > has already been applied, so I am submitting the remaining work only. > > The difference with previous changes is that in v3 rather than add tests with > pkg-config to check if dependencies are actually installed, we just set the > flags and send any warning to devnull. The change that remains in this patchset > is the fix for the other tools, which were inadvertently broken when the include > for libtracefs changed from #include <tracefs/tracefs.h> to #include <tracefs.h> > since the flags for the feature check are not set in the other tools Makefiles, > it currently only works for perf. I recommend to either take at least patch 2/5 > that moves setting the flags to tools/build/Makefile.feature or to revert the two > patches that have been applied. You can easily test the fix with the commands below: > > make -B -C tools/verification/rv VF=1 > make -B -C tools/tracing/latency VF=1 > make -B -C tools/tracing/rtla VF=1 > > from the root of the repository. Only after the feature check flags are moved to > Makefile.feature that it also fixes the other tools. Apologies for the breakage > there. Steve, are you ok with having this patchset in the perf-tools tree? Thanks, Namhyung ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3 0/5] perf build: libtraceevent, libtracefs feature check with pkg-config 2024-07-17 16:27 ` [PATCH v3 0/5] perf build: libtraceevent, libtracefs feature check with pkg-config Namhyung Kim @ 2024-07-17 16:31 ` Steven Rostedt 2024-07-17 17:18 ` Guilherme Amadio 0 siblings, 1 reply; 3+ messages in thread From: Steven Rostedt @ 2024-07-17 16:31 UTC (permalink / raw) To: Namhyung Kim Cc: Guilherme Amadio, Arnaldo Carvalho de Melo, Ian Rogers, Thorsten Leemhuis, Leo Yan, linux-perf-users, Linux Kernel Mailing List, linux-trace-kernel On Wed, 17 Jul 2024 09:27:58 -0700 Namhyung Kim <namhyung@kernel.org> wrote: > Hello, > > On Fri, Jul 12, 2024 at 12:45 PM Guilherme Amadio <amadio@gentoo.org> wrote: > > > > Hi Namhyung, Arnaldo, > > > > Here is version 3 of the patchset. I see the change to send output to devnull > > has already been applied, so I am submitting the remaining work only. > > > > The difference with previous changes is that in v3 rather than add tests with > > pkg-config to check if dependencies are actually installed, we just set the > > flags and send any warning to devnull. The change that remains in this patchset > > is the fix for the other tools, which were inadvertently broken when the include > > for libtracefs changed from #include <tracefs/tracefs.h> to #include <tracefs.h> > > since the flags for the feature check are not set in the other tools Makefiles, > > it currently only works for perf. I recommend to either take at least patch 2/5 > > that moves setting the flags to tools/build/Makefile.feature or to revert the two > > patches that have been applied. You can easily test the fix with the commands below: > > > > make -B -C tools/verification/rv VF=1 > > make -B -C tools/tracing/latency VF=1 > > make -B -C tools/tracing/rtla VF=1 > > > > from the root of the repository. Only after the feature check flags are moved to > > Makefile.feature that it also fixes the other tools. Apologies for the breakage > > there. > > Steve, are you ok with having this patchset in the perf-tools tree? > I don't know as this is the first I've seen it. If you could have this resend with me Cc'd and/or Cc linux-trace-devel@vger.kernel.org then I can review and possibly ack it. -- Steve ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3 0/5] perf build: libtraceevent, libtracefs feature check with pkg-config 2024-07-17 16:31 ` Steven Rostedt @ 2024-07-17 17:18 ` Guilherme Amadio 0 siblings, 0 replies; 3+ messages in thread From: Guilherme Amadio @ 2024-07-17 17:18 UTC (permalink / raw) To: Steven Rostedt Cc: Namhyung Kim, Arnaldo Carvalho de Melo, Ian Rogers, Thorsten Leemhuis, Leo Yan, linux-perf-users, Linux Kernel Mailing List, linux-trace-kernel On Wed, Jul 17, 2024 at 12:31:47PM -0400, Steven Rostedt wrote: > On Wed, 17 Jul 2024 09:27:58 -0700 > Namhyung Kim <namhyung@kernel.org> wrote: > > > Hello, > > > > On Fri, Jul 12, 2024 at 12:45 PM Guilherme Amadio <amadio@gentoo.org> wrote: > > > > > > Hi Namhyung, Arnaldo, > > > > > > Here is version 3 of the patchset. I see the change to send output to devnull > > > has already been applied, so I am submitting the remaining work only. > > > > > > The difference with previous changes is that in v3 rather than add tests with > > > pkg-config to check if dependencies are actually installed, we just set the > > > flags and send any warning to devnull. The change that remains in this patchset > > > is the fix for the other tools, which were inadvertently broken when the include > > > for libtracefs changed from #include <tracefs/tracefs.h> to #include <tracefs.h> > > > since the flags for the feature check are not set in the other tools Makefiles, > > > it currently only works for perf. I recommend to either take at least patch 2/5 > > > that moves setting the flags to tools/build/Makefile.feature or to revert the two > > > patches that have been applied. You can easily test the fix with the commands below: > > > > > > make -B -C tools/verification/rv VF=1 > > > make -B -C tools/tracing/latency VF=1 > > > make -B -C tools/tracing/rtla VF=1 > > > > > > from the root of the repository. Only after the feature check flags are moved to > > > Makefile.feature that it also fixes the other tools. Apologies for the breakage > > > there. > > > > Steve, are you ok with having this patchset in the perf-tools tree? > > > > I don't know as this is the first I've seen it. If you could have this > resend with me Cc'd and/or Cc linux-trace-devel@vger.kernel.org then I > can review and possibly ack it. I will resend with the extra CC suggestions shortly and a cover letter explaining everything. Best regards, -Guilherme ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-17 17:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CAM9d7ciLGP_w9YYOb-2U2ESg8kQx_knQXuB6_2JZVZ2ktL+bzg@mail.gmail.com>
[not found] ` <20240712194511.3973899-1-amadio@gentoo.org>
2024-07-17 16:27 ` [PATCH v3 0/5] perf build: libtraceevent, libtracefs feature check with pkg-config Namhyung Kim
2024-07-17 16:31 ` Steven Rostedt
2024-07-17 17:18 ` Guilherme Amadio
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).