* [PATCH bpf-next] bpf: kprobe: remove unused declaring of bpf_kprobe_override
@ 2024-07-10 8:59 Menglong Dong
2024-07-10 13:13 ` Jiri Olsa
0 siblings, 1 reply; 5+ messages in thread
From: Menglong Dong @ 2024-07-10 8:59 UTC (permalink / raw)
To: mhiramat
Cc: rostedt, mathieu.desnoyers, linux-kernel, linux-trace-kernel, bpf,
Menglong Dong
After the commit 66665ad2f102 ("tracing/kprobe: bpf: Compare instruction
pointer with original one"), "bpf_kprobe_override" is not used anywhere
anymore, and we can remove it now.
Signed-off-by: Menglong Dong <dongml2@chinatelecom.cn>
---
include/linux/trace_events.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/linux/trace_events.h b/include/linux/trace_events.h
index 9df3e2973626..9435185c10ef 100644
--- a/include/linux/trace_events.h
+++ b/include/linux/trace_events.h
@@ -880,7 +880,6 @@ do { \
struct perf_event;
DECLARE_PER_CPU(struct pt_regs, perf_trace_regs);
-DECLARE_PER_CPU(int, bpf_kprobe_override);
extern int perf_trace_init(struct perf_event *event);
extern void perf_trace_destroy(struct perf_event *event);
--
2.39.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH bpf-next] bpf: kprobe: remove unused declaring of bpf_kprobe_override
2024-07-10 8:59 [PATCH bpf-next] bpf: kprobe: remove unused declaring of bpf_kprobe_override Menglong Dong
@ 2024-07-10 13:13 ` Jiri Olsa
2024-07-10 14:18 ` Masami Hiramatsu
0 siblings, 1 reply; 5+ messages in thread
From: Jiri Olsa @ 2024-07-10 13:13 UTC (permalink / raw)
To: Menglong Dong
Cc: mhiramat, rostedt, mathieu.desnoyers, linux-kernel,
linux-trace-kernel, bpf, Menglong Dong
On Wed, Jul 10, 2024 at 04:59:39PM +0800, Menglong Dong wrote:
> After the commit 66665ad2f102 ("tracing/kprobe: bpf: Compare instruction
should be in Fixes: tag probably ?
> pointer with original one"), "bpf_kprobe_override" is not used anywhere
> anymore, and we can remove it now.
>
> Signed-off-by: Menglong Dong <dongml2@chinatelecom.cn>
lgtm, cc-ing Masami
Acked-by: Jiri Olsa <jolsa@kernel.org>
jirka
> ---
> include/linux/trace_events.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/trace_events.h b/include/linux/trace_events.h
> index 9df3e2973626..9435185c10ef 100644
> --- a/include/linux/trace_events.h
> +++ b/include/linux/trace_events.h
> @@ -880,7 +880,6 @@ do { \
> struct perf_event;
>
> DECLARE_PER_CPU(struct pt_regs, perf_trace_regs);
> -DECLARE_PER_CPU(int, bpf_kprobe_override);
>
> extern int perf_trace_init(struct perf_event *event);
> extern void perf_trace_destroy(struct perf_event *event);
> --
> 2.39.2
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH bpf-next] bpf: kprobe: remove unused declaring of bpf_kprobe_override
2024-07-10 13:13 ` Jiri Olsa
@ 2024-07-10 14:18 ` Masami Hiramatsu
2024-07-18 1:32 ` Menglong Dong
0 siblings, 1 reply; 5+ messages in thread
From: Masami Hiramatsu @ 2024-07-10 14:18 UTC (permalink / raw)
To: Jiri Olsa
Cc: Menglong Dong, mhiramat, rostedt, mathieu.desnoyers, linux-kernel,
linux-trace-kernel, bpf, Menglong Dong
On Wed, 10 Jul 2024 15:13:07 +0200
Jiri Olsa <olsajiri@gmail.com> wrote:
> On Wed, Jul 10, 2024 at 04:59:39PM +0800, Menglong Dong wrote:
> > After the commit 66665ad2f102 ("tracing/kprobe: bpf: Compare instruction
>
> should be in Fixes: tag probably ?
Yes, I'll add a Fixed tag.
>
> > pointer with original one"), "bpf_kprobe_override" is not used anywhere
> > anymore, and we can remove it now.
> >
> > Signed-off-by: Menglong Dong <dongml2@chinatelecom.cn>
>
> lgtm, cc-ing Masami
>
> Acked-by: Jiri Olsa <jolsa@kernel.org>
Thanks!
>
> jirka
>
> > ---
> > include/linux/trace_events.h | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/include/linux/trace_events.h b/include/linux/trace_events.h
> > index 9df3e2973626..9435185c10ef 100644
> > --- a/include/linux/trace_events.h
> > +++ b/include/linux/trace_events.h
> > @@ -880,7 +880,6 @@ do { \
> > struct perf_event;
> >
> > DECLARE_PER_CPU(struct pt_regs, perf_trace_regs);
> > -DECLARE_PER_CPU(int, bpf_kprobe_override);
> >
> > extern int perf_trace_init(struct perf_event *event);
> > extern void perf_trace_destroy(struct perf_event *event);
> > --
> > 2.39.2
> >
> >
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH bpf-next] bpf: kprobe: remove unused declaring of bpf_kprobe_override
2024-07-10 14:18 ` Masami Hiramatsu
@ 2024-07-18 1:32 ` Menglong Dong
2024-07-18 14:51 ` Masami Hiramatsu
0 siblings, 1 reply; 5+ messages in thread
From: Menglong Dong @ 2024-07-18 1:32 UTC (permalink / raw)
To: Masami Hiramatsu, Jiri Olsa
Cc: rostedt, mathieu.desnoyers, linux-kernel, linux-trace-kernel, bpf,
Menglong Dong
On Wed, Jul 10, 2024 at 10:18 PM Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> On Wed, 10 Jul 2024 15:13:07 +0200
> Jiri Olsa <olsajiri@gmail.com> wrote:
>
> > On Wed, Jul 10, 2024 at 04:59:39PM +0800, Menglong Dong wrote:
> > > After the commit 66665ad2f102 ("tracing/kprobe: bpf: Compare instruction
> >
> > should be in Fixes: tag probably ?
>
> Yes, I'll add a Fixed tag.
>
Hello!
Should I send a v2 with the "Fixes" tag? It seems that this commit has
been pending for a while.
Thanks!
Menglong Dong
> >
> > > pointer with original one"), "bpf_kprobe_override" is not used anywhere
> > > anymore, and we can remove it now.
> > >
> > > Signed-off-by: Menglong Dong <dongml2@chinatelecom.cn>
> >
> > lgtm, cc-ing Masami
> >
> > Acked-by: Jiri Olsa <jolsa@kernel.org>
>
> Thanks!
>
> >
> > jirka
> >
> > > ---
> > > include/linux/trace_events.h | 1 -
> > > 1 file changed, 1 deletion(-)
> > >
> > > diff --git a/include/linux/trace_events.h b/include/linux/trace_events.h
> > > index 9df3e2973626..9435185c10ef 100644
> > > --- a/include/linux/trace_events.h
> > > +++ b/include/linux/trace_events.h
> > > @@ -880,7 +880,6 @@ do { \
> > > struct perf_event;
> > >
> > > DECLARE_PER_CPU(struct pt_regs, perf_trace_regs);
> > > -DECLARE_PER_CPU(int, bpf_kprobe_override);
> > >
> > > extern int perf_trace_init(struct perf_event *event);
> > > extern void perf_trace_destroy(struct perf_event *event);
> > > --
> > > 2.39.2
> > >
> > >
>
>
> --
> Masami Hiramatsu (Google) <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH bpf-next] bpf: kprobe: remove unused declaring of bpf_kprobe_override
2024-07-18 1:32 ` Menglong Dong
@ 2024-07-18 14:51 ` Masami Hiramatsu
0 siblings, 0 replies; 5+ messages in thread
From: Masami Hiramatsu @ 2024-07-18 14:51 UTC (permalink / raw)
To: Menglong Dong
Cc: Jiri Olsa, rostedt, mathieu.desnoyers, linux-kernel,
linux-trace-kernel, bpf, Menglong Dong
Hi,
On Thu, 18 Jul 2024 09:32:13 +0800
Menglong Dong <menglong8.dong@gmail.com> wrote:
> On Wed, Jul 10, 2024 at 10:18 PM Masami Hiramatsu <mhiramat@kernel.org> wrote:
> >
> > On Wed, 10 Jul 2024 15:13:07 +0200
> > Jiri Olsa <olsajiri@gmail.com> wrote:
> >
> > > On Wed, Jul 10, 2024 at 04:59:39PM +0800, Menglong Dong wrote:
> > > > After the commit 66665ad2f102 ("tracing/kprobe: bpf: Compare instruction
> > >
> > > should be in Fixes: tag probably ?
> >
> > Yes, I'll add a Fixed tag.
> >
>
> Hello!
>
> Should I send a v2 with the "Fixes" tag? It seems that this commit has
> been pending for a while.
No problem, but wait a bit. I need to send this to 6.11-rc1.
Thank you,
>
> Thanks!
> Menglong Dong
>
> > >
> > > > pointer with original one"), "bpf_kprobe_override" is not used anywhere
> > > > anymore, and we can remove it now.
> > > >
> > > > Signed-off-by: Menglong Dong <dongml2@chinatelecom.cn>
> > >
> > > lgtm, cc-ing Masami
> > >
> > > Acked-by: Jiri Olsa <jolsa@kernel.org>
> >
> > Thanks!
> >
> > >
> > > jirka
> > >
> > > > ---
> > > > include/linux/trace_events.h | 1 -
> > > > 1 file changed, 1 deletion(-)
> > > >
> > > > diff --git a/include/linux/trace_events.h b/include/linux/trace_events.h
> > > > index 9df3e2973626..9435185c10ef 100644
> > > > --- a/include/linux/trace_events.h
> > > > +++ b/include/linux/trace_events.h
> > > > @@ -880,7 +880,6 @@ do { \
> > > > struct perf_event;
> > > >
> > > > DECLARE_PER_CPU(struct pt_regs, perf_trace_regs);
> > > > -DECLARE_PER_CPU(int, bpf_kprobe_override);
> > > >
> > > > extern int perf_trace_init(struct perf_event *event);
> > > > extern void perf_trace_destroy(struct perf_event *event);
> > > > --
> > > > 2.39.2
> > > >
> > > >
> >
> >
> > --
> > Masami Hiramatsu (Google) <mhiramat@kernel.org>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-07-18 14:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-10 8:59 [PATCH bpf-next] bpf: kprobe: remove unused declaring of bpf_kprobe_override Menglong Dong
2024-07-10 13:13 ` Jiri Olsa
2024-07-10 14:18 ` Masami Hiramatsu
2024-07-18 1:32 ` Menglong Dong
2024-07-18 14:51 ` Masami Hiramatsu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).