linux-trace-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mathias Krause <minipli@grsecurity.net>
To: Steven Rostedt <rostedt@goodmis.org>,
	Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mathias Krause <minipli@grsecurity.net>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org,
	Ajay Kaher <ajay.kaher@broadcom.com>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: [PATCH] eventfs: Use SRCU for freeing eventfs_inodes
Date: Tue, 23 Jul 2024 23:07:53 +0200	[thread overview]
Message-ID: <20240723210755.8970-1-minipli@grsecurity.net> (raw)
In-Reply-To: <20240723104348.645bf027@gandalf.local.home>

To mirror the SRCU lock held in eventfs_iterate() when iterating over
eventfs inodes, use call_srcu() to free them too.

This was accidentally(?) degraded to RCU in commit 43aa6f97c2d0
("eventfs: Get rid of dentry pointers without refcounts").

Cc: Ajay Kaher <ajay.kaher@broadcom.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Fixes: 43aa6f97c2d0 ("eventfs: Get rid of dentry pointers without refcounts")
Signed-off-by: Mathias Krause <minipli@grsecurity.net>
---
 fs/tracefs/event_inode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/tracefs/event_inode.c b/fs/tracefs/event_inode.c
index a9c28a1d5dc8..01e99e98457d 100644
--- a/fs/tracefs/event_inode.c
+++ b/fs/tracefs/event_inode.c
@@ -112,7 +112,7 @@ static void release_ei(struct kref *ref)
 			entry->release(entry->name, ei->data);
 	}
 
-	call_rcu(&ei->rcu, free_ei_rcu);
+	call_srcu(&eventfs_srcu, &ei->rcu, free_ei_rcu);
 }
 
 static inline void put_ei(struct eventfs_inode *ei)
-- 
2.43.0


  parent reply	other threads:[~2024-07-23 21:08 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-19 20:47 tracing: user events UAF crash report Mathias Krause
2024-07-20  3:33 ` Dan Carpenter
2024-07-22 11:13 ` Ajay Kaher
2024-07-22 12:08   ` Mathias Krause
2024-07-25 13:33     ` Ajay Kaher
2024-07-25 16:15       ` Ajay Kaher
2024-07-25 16:30         ` Ajay Kaher
2024-07-25 17:10           ` Steven Rostedt
2024-07-25 17:16             ` Steven Rostedt
2024-07-25 18:12               ` Mathias Krause
2024-07-25 19:05                 ` Steven Rostedt
2024-07-25 19:42                   ` Mathias Krause
2024-07-25 20:15                     ` Steven Rostedt
2024-07-25 20:41                       ` Mathias Krause
2024-07-25 21:14                         ` Steven Rostedt
2024-07-25 21:32                           ` Mathias Krause
2024-07-25 23:06                             ` Steven Rostedt
2024-07-26  8:25                               ` Mathias Krause
2024-07-25 19:53                   ` Mathias Krause
2024-07-25 16:48         ` Steven Rostedt
2024-07-23  0:11 ` Steven Rostedt
2024-07-23 12:25   ` [PATCH] eventfs: Don't return NULL in eventfs_create_dir() Mathias Krause
2024-07-23 14:43 ` tracing: user events UAF crash report Steven Rostedt
2024-07-23 20:54   ` Mathias Krause
2024-07-23 21:07   ` Mathias Krause [this message]
2024-07-23 21:23     ` [PATCH] eventfs: Use SRCU for freeing eventfs_inodes Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240723210755.8970-1-minipli@grsecurity.net \
    --to=minipli@grsecurity.net \
    --cc=ajay.kaher@broadcom.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).