From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux trace kernel <linux-trace-kernel@vger.kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Subject: Re: [PATCH] tracing: Use refcount for trace_event_file reference counter
Date: Tue, 30 Jul 2024 09:02:21 +0900 [thread overview]
Message-ID: <20240730090221.7fea5eaedddce5de4e43914a@kernel.org> (raw)
In-Reply-To: <20240729190241.47e52c05@rorschach.local.home>
On Mon, 29 Jul 2024 19:02:41 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Mon, 29 Jul 2024 23:49:24 +0900
> Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:
>
> > On Fri, 26 Jul 2024 14:42:08 -0400
> > Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > > From: Steven Rostedt <rostedt@goodmis.org>
> > >
> > > Instead of using an atomic counter for the trace_event_file reference
> > > counter, use the refcount interface. It has various checks to make sure
> > > the reference counting is correct, and will warn if it detects an error
> > > (like refcount_inc() on '0').
> > >
> > > Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
> >
> > Looks good to me.
> >
> > Masami Hiramatsu (Google) <mhiramat@kernel.org>
>
> Is that an ack or a review? ;-)
It was Ack,
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Sorry about that. I might be too sleep.
>
> -- Steve
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
prev parent reply other threads:[~2024-07-30 0:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-26 18:42 [PATCH] tracing: Use refcount for trace_event_file reference counter Steven Rostedt
2024-07-29 14:49 ` Masami Hiramatsu
2024-07-29 23:02 ` Steven Rostedt
2024-07-30 0:02 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240730090221.7fea5eaedddce5de4e43914a@kernel.org \
--to=mhiramat@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).