From: Mathias Krause <minipli@grsecurity.net>
To: Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mathias Krause <minipli@grsecurity.net>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Ajay Kaher <ajay.kaher@broadcom.com>,
linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] tracefs: inode alloc/free related fixes
Date: Wed, 7 Aug 2024 13:51:37 +0200 [thread overview]
Message-ID: <20240807115143.45927-1-minipli@grsecurity.net> (raw)
Hi Steven,
We ran into yet another tracefs related bug but, fortunately, were able
to root cause it ourselves.
The problem only occurs when CONFIG_RANDSTRUCT is enabled and one gets
(un)lucky to hit a random seed that'll overlay the 'rcu' member of the
union with a list_head in 'vfs_inode' -- quite unlikely but, apparently,
we're exceptional "lucky" with our testing ;)
The first patch is more of an API correctness fix, to bring the tracefs
inode cache in line with all the other filesystems. The second patch
actually fixes the bug, which, I think, may also be the cause for what
Ilkka is seeing[1].
Please apply!
Thanks,
Mathias
[1] https://lore.kernel.org/all/CAE4VaREzY+a2PvQJYJbfh8DwB4OP7kucZG-e28H22xyWob1w_A@mail.gmail.com/
Mathias Krause (2):
tracefs: Fix inode allocation
tracefs: Don't overlay 'struct inode'
fs/tracefs/inode.c | 2 +-
fs/tracefs/internal.h | 6 ++----
2 files changed, 3 insertions(+), 5 deletions(-)
--
2.43.0
next reply other threads:[~2024-08-07 11:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-07 11:51 Mathias Krause [this message]
2024-08-07 11:51 ` [PATCH 1/2] tracefs: Fix inode allocation Mathias Krause
2024-08-07 11:51 ` [PATCH 2/2] tracefs: Don't overlay 'struct inode' Mathias Krause
2024-08-07 13:35 ` Steven Rostedt
2024-08-07 13:44 ` Al Viro
2024-08-07 15:49 ` Steven Rostedt
2024-08-07 20:27 ` Mathias Krause
2024-08-07 20:24 ` Mathias Krause
2024-08-07 20:19 ` Mathias Krause
2024-08-07 13:34 ` [PATCH 0/2] tracefs: inode alloc/free related fixes Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240807115143.45927-1-minipli@grsecurity.net \
--to=minipli@grsecurity.net \
--cc=ajay.kaher@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox