From: Oleg Nesterov <oleg@redhat.com>
To: "Liao, Chang" <liaochang1@huawei.com>
Cc: mhiramat@kernel.org, peterz@infradead.org, mingo@redhat.com,
acme@kernel.org, namhyung@kernel.org, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, jolsa@kernel.org,
irogers@google.com, adrian.hunter@intel.com,
kan.liang@linux.intel.com, andrii@kernel.org,
rostedt@goodmis.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org,
linux-perf-users@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH v2 1/2] uprobes: Remove redundant spinlock in uprobe_deny_signal()
Date: Tue, 13 Aug 2024 14:47:37 +0200 [thread overview]
Message-ID: <20240813124737.GA31977@redhat.com> (raw)
In-Reply-To: <2971107e-75e7-8438-c858-b95202d7b5ea@huawei.com>
On 08/13, Liao, Chang wrote:
>
>
> Oleg, your explaination is more accurate. So I will reword the commit log and
> quote some of your note like this:
Oh, please don't. I just tried to explain the history of this spin_lock(siglock).
> Since we already have the lockless user of clear_thread_flag(TIF_SIGPENDING).
> And for uprobe singlestep case, it doesn't break the rule of "the state of
> TIF_SIGPENDING of every thread is stable with sighand->siglock held".
It obviously does break the rule above. Please keep your changelog as is.
Oleg.
next prev parent reply other threads:[~2024-08-13 12:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-09 6:10 [PATCH v2 0/2] uprobes: Improve scalability by reducing the contention on siglock Liao Chang
2024-08-09 6:10 ` [PATCH v2 1/2] uprobes: Remove redundant spinlock in uprobe_deny_signal() Liao Chang
2024-08-12 12:07 ` Oleg Nesterov
2024-08-13 12:30 ` Liao, Chang
2024-08-13 12:47 ` Oleg Nesterov [this message]
2024-09-05 20:53 ` Andrii Nakryiko
2024-08-09 6:10 ` [PATCH v2 2/2] uprobes: Remove the spinlock within handle_singlestep() Liao Chang
2024-08-12 11:29 ` Oleg Nesterov
2024-08-13 12:30 ` Liao, Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240813124737.GA31977@redhat.com \
--to=oleg@redhat.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=liaochang1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).