From: Oleg Nesterov <oleg@redhat.com>
To: Andrii Nakryiko <andrii@kernel.org>
Cc: linux-trace-kernel@vger.kernel.org, rostedt@goodmis.org,
mhiramat@kernel.org, peterz@infradead.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org, jolsa@kernel.org
Subject: Re: [PATCH v2] uprobes: make trace_uprobe->nhit counter a per-CPU one
Date: Tue, 13 Aug 2024 16:50:03 +0200 [thread overview]
Message-ID: <20240813145002.GB31977@redhat.com> (raw)
In-Reply-To: <20240809192357.4061484-1-andrii@kernel.org>
On 08/09, Andrii Nakryiko wrote:
>
> @@ -815,13 +824,21 @@ static int probes_profile_seq_show(struct seq_file *m, void *v)
> {
> struct dyn_event *ev = v;
> struct trace_uprobe *tu;
> + unsigned long nhits;
> + int cpu;
>
> if (!is_trace_uprobe(ev))
> return 0;
>
> tu = to_trace_uprobe(ev);
> +
> + nhits = 0;
> + for_each_possible_cpu(cpu) {
> + nhits += READ_ONCE(*per_cpu_ptr(tu->nhits, cpu));
why not
nhits += per_cpu(*tu->nhits, cpu);
?
See for example per_cpu_sum() or nr_processes(), per_cpu() should work just fine...
Other than that
Reviewed-by: Oleg Nesterov <oleg@redhat.com>
next prev parent reply other threads:[~2024-08-13 14:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-09 19:23 [PATCH v2] uprobes: make trace_uprobe->nhit counter a per-CPU one Andrii Nakryiko
2024-08-13 13:30 ` Masami Hiramatsu
2024-08-13 15:41 ` Oleg Nesterov
2024-08-25 10:15 ` Masami Hiramatsu
2024-08-26 16:17 ` Andrii Nakryiko
2024-08-13 14:50 ` Oleg Nesterov [this message]
2024-08-13 17:05 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240813145002.GB31977@redhat.com \
--to=oleg@redhat.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).