From: Jan Kara <jack@suse.cz>
To: Julian Sun <sunjunchao2870@gmail.com>
Cc: linux-trace-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, jack@suse.cz, brauner@kernel.org,
viro@zeniv.linux.org.uk, mhiramat@kernel.org,
rostedt@goodmis.org, mathieu.desnoyers@efficios.com
Subject: Re: [PATCH v2] writeback: Refine the show_inode_state() macro definition
Date: Wed, 28 Aug 2024 17:08:53 +0200 [thread overview]
Message-ID: <20240828150853.st5s4q5bxz4wbgdd@quack3> (raw)
In-Reply-To: <20240828081359.62429-1-sunjunchao2870@gmail.com>
On Wed 28-08-24 16:13:59, Julian Sun wrote:
> Currently, the show_inode_state() macro only prints
> part of the state of inode->i_state. Let’s improve it
> to display more of its state.
>
> Signed-off-by: Julian Sun <sunjunchao2870@gmail.com>
Looks good to me. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> include/trace/events/writeback.h | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/include/trace/events/writeback.h b/include/trace/events/writeback.h
> index 54e353c9f919..a261e86e61fa 100644
> --- a/include/trace/events/writeback.h
> +++ b/include/trace/events/writeback.h
> @@ -20,7 +20,15 @@
> {I_CLEAR, "I_CLEAR"}, \
> {I_SYNC, "I_SYNC"}, \
> {I_DIRTY_TIME, "I_DIRTY_TIME"}, \
> - {I_REFERENCED, "I_REFERENCED"} \
> + {I_REFERENCED, "I_REFERENCED"}, \
> + {I_LINKABLE, "I_LINKABLE"}, \
> + {I_WB_SWITCH, "I_WB_SWITCH"}, \
> + {I_OVL_INUSE, "I_OVL_INUSE"}, \
> + {I_CREATING, "I_CREATING"}, \
> + {I_DONTCACHE, "I_DONTCACHE"}, \
> + {I_SYNC_QUEUED, "I_SYNC_QUEUED"}, \
> + {I_PINNING_NETFS_WB, "I_PINNING_NETFS_WB"}, \
> + {I_LRU_ISOLATING, "I_LRU_ISOLATING"} \
> )
>
> /* enums need to be exported to user space */
> --
> 2.39.2
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2024-08-28 15:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 8:13 [PATCH v2] writeback: Refine the show_inode_state() macro definition Julian Sun
2024-08-28 15:08 ` Jan Kara [this message]
2024-08-29 12:04 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240828150853.st5s4q5bxz4wbgdd@quack3 \
--to=jack@suse.cz \
--cc=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=sunjunchao2870@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox