From: Vincent Donnefort <vdonnefort@google.com>
To: rostedt@goodmis.org
Cc: mhiramat@kernel.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org,
mathieu.desnoyers@efficios.com, kernel-team@android.com,
david@redhat.com, Vincent Donnefort <vdonnefort@google.com>
Subject: [PATCH 1/2] ring-buffer/selftest: Verify the entire meta-page padding
Date: Wed, 28 Aug 2024 16:40:39 +0100 [thread overview]
Message-ID: <20240828154040.2803428-1-vdonnefort@google.com> (raw)
In-Reply-To: <20240821115636.3546f684@gandalf.local.home>
Improve the ring-buffer meta-page test coverage by checking for the
entire padding region to be 0 instead of just looking at the first 4
bytes.
Signed-off-by: Vincent Donnefort <vdonnefort@google.com>
--
Hi,
I saw you have sent "Align meta-page to sub-buffers for improved TLB usage" to
linux-next, so here's a follow-up patch addressing your comments, not sure if
you want to squash it or to put it on top.
diff --git a/tools/testing/selftests/ring-buffer/map_test.c b/tools/testing/selftests/ring-buffer/map_test.c
index 4bb0192e43f3..ba12fd31de87 100644
--- a/tools/testing/selftests/ring-buffer/map_test.c
+++ b/tools/testing/selftests/ring-buffer/map_test.c
@@ -231,15 +231,15 @@ TEST_F(map, data_mmap)
/* Verify meta-page padding */
if (desc->meta->meta_page_size > getpagesize()) {
- void *addr;
-
data_len = desc->meta->meta_page_size;
data = mmap(NULL, data_len,
PROT_READ, MAP_SHARED, desc->cpu_fd, 0);
ASSERT_NE(data, MAP_FAILED);
- addr = (void *)((unsigned long)data + getpagesize());
- ASSERT_EQ(*((int *)addr), 0);
+ for (int i = desc->meta->meta_struct_len;
+ i < desc->meta->meta_page_size; i += sizeof(int))
+ ASSERT_EQ(*(int *)(data + i), 0);
+
munmap(data, data_len);
}
}
base-commit: 2a07e30c19f391af26517c409fd66e401c6f4ee7
prerequisite-patch-id: 16b79d676c5faf3b57443b576976c7522fcd5a4b
--
2.46.0.295.g3b9ea8a38a-goog
next prev parent reply other threads:[~2024-08-28 15:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-28 10:46 [PATCH v2] ring-buffer: Align meta-page to sub-buffers for improved TLB usage Vincent Donnefort
2024-07-15 18:59 ` Steven Rostedt
2024-08-21 15:56 ` Steven Rostedt
2024-08-28 15:40 ` Vincent Donnefort [this message]
2024-08-28 15:40 ` [PATCH 2/2] ring-buffer/selftest: Handle meta-page bigger than the system Vincent Donnefort
-- strict thread matches above, loose matches on Subject: below --
2024-09-10 14:43 [PATCH 0/2] ring-buffer/selftest: Meta-page testing improvements Vincent Donnefort
2024-09-10 14:43 ` [PATCH 1/2] ring-buffer/selftest: Verify the entire meta-page padding Vincent Donnefort
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240828154040.2803428-1-vdonnefort@google.com \
--to=vdonnefort@google.com \
--cc=david@redhat.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox