From: Christoph Hellwig <hch@lst.de>
To: Sean Anderson <sean.anderson@linux.dev>
Cc: Christoph Hellwig <hch@lst.de>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Robin Murphy <robin.murphy@arm.com>,
iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH v3] dma: Trace API
Date: Tue, 3 Sep 2024 09:25:12 +0200 [thread overview]
Message-ID: <20240903072512.GA1521@lst.de> (raw)
In-Reply-To: <4c2c6b24-aee1-495f-ab47-662e1e818f4b@linux.dev>
On Thu, Aug 29, 2024 at 10:24:52AM -0400, Sean Anderson wrote:
> >> When debugging drivers, it can often be useful to trace when memory gets
> >> (un)mapped for DMA (and can be accessed by the device). Add some
> >> tracepoints for this purpose.
> >>
> >> We use unsigned long long instead of phys_addr_t and dma_addr_t (and
> >> similarly %llx instead of %pa) because libtraceevent can't handle
> >> typedefs.
> >
> > and a __u64 would seem like the better type here.
>
> libtraceevent can't handle typedefs, including u64.
Weird. The xfs trace events which were some of the first ever are full
of typedefs and no one ever complained. And looking at other
trace event definitions they are full of it.
I've added the tracing maintainers to see if we can shed some light
on this issue.
next parent reply other threads:[~2024-09-03 7:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240826203240.2234615-1-sean.anderson@linux.dev>
[not found] ` <20240829041912.GB4408@lst.de>
[not found] ` <4c2c6b24-aee1-495f-ab47-662e1e818f4b@linux.dev>
2024-09-03 7:25 ` Christoph Hellwig [this message]
2024-09-03 13:21 ` [PATCH v3] dma: Trace API Steven Rostedt
2024-09-03 14:36 ` Sean Anderson
2024-09-04 0:53 ` Steven Rostedt
2024-09-04 4:15 ` Christoph Hellwig
2024-09-05 17:00 ` Sean Anderson
2024-09-05 16:59 ` Sean Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240903072512.GA1521@lst.de \
--to=hch@lst.de \
--cc=iommu@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=robin.murphy@arm.com \
--cc=rostedt@goodmis.org \
--cc=sean.anderson@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).