From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9402E13D251; Fri, 6 Sep 2024 22:23:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725661382; cv=none; b=TojlMoer+P0hZmrWv2M1Hp9F7nK+vUDMR/uWZulLyrwpmAy4QEFVTDdul7n/UK2g7xrHz3zTp/7p0nsfxWct0DtOQjn7DnU5UQhPcYB1OGhaDjR1pN/O2UYGlMZal7qjSAhlOkOqzoqgURnfAtKDamdkFWrujN8VHkAdkSzhY8w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725661382; c=relaxed/simple; bh=GKaXF1yioOTb9F5s7ndE5NHY1EH9yLQe0g4ySiSwE30=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pCRqDmobO0M+Q9U50CArydtlfBkS7T8iCAJPMPYWwVRlt9G/BXopgm7XzepFYRu9tMAD9MbD22Kt6n/S3ub67l0hA3BS3LQRj3KIq69IpvrTTgE7CbpV28mF3NAzyrhjrvzszJ2W0LEKs9SI9ZZqachcSiUkzzhSM4u4pjGWLaQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=G3bIZrwM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="G3bIZrwM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3E22C4CEC4; Fri, 6 Sep 2024 22:23:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725661382; bh=GKaXF1yioOTb9F5s7ndE5NHY1EH9yLQe0g4ySiSwE30=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=G3bIZrwMKqqIeo9tZrmgmFG1n6C49TknaHmotoG0W/l825gogN2HJIUq2RGsK02YO yzNq7ugIdrhwUbGKs4ncrn332dEfMlNB14OlNPZarFYSsnBQBCTLsRXqoDhafXRYv3 m26Ku/AQi+6Le7aiS8nLoceZD6QrbEx8yjM97dB8nN96Ts6/eF20ukCxUfBLYxoPcD KF+M/txfi4qwaCnEF6uVqyzr4PzpuCe965rUFuuGrxNtj28J2a9JSndsui71x6FRIF FmPtANWVnBkgYnwhIcn1Jf0KWOvUnOcsc2S2TsSzO67ldw3GiGo7F8D87HXsTsa7S8 jEMZEFzUJNYXg== Date: Fri, 6 Sep 2024 15:23:00 -0700 From: Jakub Kicinski To: Alexei Starovoitov Cc: Philo Lu , bpf , Eric Dumazet , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Martin KaFai Lau , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eddy Z , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , "David S. Miller" , Paolo Abeni , Mykola Lysenko , Shuah Khan , Maxime Coquelin , Alexandre Torgue , Kui-Feng Lee , Juntong Deng , jrife@google.com, Alan Maguire , Dave Marchevsky , Daniel Xu , Viktor Malik , Cupertino Miranda , Matt Bobrowski , Xuan Zhuo , Network Development , linux-trace-kernel Subject: Re: [PATCH bpf-next v2 3/5] tcp: Use skb__nullable in trace_tcp_send_reset Message-ID: <20240906152300.634e950b@kernel.org> In-Reply-To: References: <20240905075622.66819-1-lulie@linux.alibaba.com> <20240905075622.66819-4-lulie@linux.alibaba.com> Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 5 Sep 2024 17:26:42 -0700 Alexei Starovoitov wrote: > Yes, it's a bit of a whack a mole and eventually we can get rid of it > with a smarter verifier (likely) or smarter objtool (unlikely). > Long term we should be able to analyze body of TP_fast_assign > automatically and conclude whether it's handling NULL for pointer > arguments or not. bpf verifier can easily do it for bpf code. > We just need to compile TP_fast_assign() as a tiny bpf snippet. > This is work in progress. Can we not wait for that work to conclude, then? AFAIU this whole patch set is just a minor quality of life improvement for BPF progs at the expense of carrying questionable changes upstream. I don't see the urgency.