From: Jakub Kicinski <kuba@kernel.org>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Philo Lu <lulie@linux.alibaba.com>, bpf <bpf@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Martin KaFai Lau <martin.lau@linux.dev>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>, Eddy Z <eddyz87@gmail.com>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>, Mykola Lysenko <mykolal@fb.com>,
Shuah Khan <shuah@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Kui-Feng Lee <thinker.li@gmail.com>,
Juntong Deng <juntong.deng@outlook.com>,
jrife@google.com, Alan Maguire <alan.maguire@oracle.com>,
Dave Marchevsky <davemarchevsky@fb.com>,
Daniel Xu <dxu@dxuuu.xyz>, Viktor Malik <vmalik@redhat.com>,
Cupertino Miranda <cupertino.miranda@oracle.com>,
Matt Bobrowski <mattbobrowski@google.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
Network Development <netdev@vger.kernel.org>,
linux-trace-kernel <linux-trace-kernel@vger.kernel.org>
Subject: Re: [PATCH bpf-next v2 3/5] tcp: Use skb__nullable in trace_tcp_send_reset
Date: Fri, 6 Sep 2024 15:57:42 -0700 [thread overview]
Message-ID: <20240906155742.0bd4d4e3@kernel.org> (raw)
In-Reply-To: <CAADnVQJWm_CJobz71_FRPTFeVojHLgmYmQA4tVhOg3MDP2V2Dw@mail.gmail.com>
On Fri, 6 Sep 2024 15:41:47 -0700 Alexei Starovoitov wrote:
> The urgency is now because the situation is dire.
> The verifier assumes that skb is not null and will remove
> if (!skb) check assuming that it's a dead code.
Meaning verifier currently isn't ready for patch 4?
Or we can crash 6.11-rc6 by attaching to a trace_tcp_send_reset()
and doing
printf("%d\n", skb->len);
?
next prev parent reply other threads:[~2024-09-06 22:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 7:56 [PATCH bpf-next v2 0/5] bpf: Allow skb dynptr for tp_btf Philo Lu
2024-09-05 7:56 ` [PATCH bpf-next v2 1/5] bpf: Support __nullable argument suffix " Philo Lu
2024-09-06 21:25 ` Andrii Nakryiko
2024-09-07 3:26 ` Philo Lu
2024-09-07 1:14 ` Andrii Nakryiko
2024-09-05 7:56 ` [PATCH bpf-next v2 2/5] selftests/bpf: Add test for __nullable suffix in tp_btf Philo Lu
2024-09-06 21:25 ` Andrii Nakryiko
2024-09-05 7:56 ` [PATCH bpf-next v2 3/5] tcp: Use skb__nullable in trace_tcp_send_reset Philo Lu
2024-09-06 0:26 ` Alexei Starovoitov
2024-09-06 22:23 ` Jakub Kicinski
2024-09-06 22:41 ` Alexei Starovoitov
2024-09-06 22:57 ` Jakub Kicinski [this message]
2024-09-06 23:22 ` Alexei Starovoitov
2024-09-07 0:17 ` Jakub Kicinski
2024-09-05 7:56 ` [PATCH bpf-next v2 4/5] bpf: Allow bpf_dynptr_from_skb() for tp_btf Philo Lu
2024-09-06 1:13 ` Martin KaFai Lau
2024-09-05 7:56 ` [PATCH bpf-next v2 5/5] selftests/bpf: Expand skb dynptr selftests " Philo Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240906155742.0bd4d4e3@kernel.org \
--to=kuba@kernel.org \
--cc=alan.maguire@oracle.com \
--cc=alexandre.torgue@foss.st.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=cupertino.miranda@oracle.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=davemarchevsky@fb.com \
--cc=dxu@dxuuu.xyz \
--cc=eddyz87@gmail.com \
--cc=edumazet@google.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=jrife@google.com \
--cc=juntong.deng@outlook.com \
--cc=kpsingh@kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=lulie@linux.alibaba.com \
--cc=martin.lau@linux.dev \
--cc=mathieu.desnoyers@efficios.com \
--cc=mattbobrowski@google.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mhiramat@kernel.org \
--cc=mykolal@fb.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rostedt@goodmis.org \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=thinker.li@gmail.com \
--cc=vmalik@redhat.com \
--cc=xuanzhuo@linux.alibaba.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).