From: Steven Rostedt <rostedt@goodmis.org>
To: Tiezhu Yang <yangtiezhu@loongson.cn>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Question about config UPROBES and UPROBE_EVENTS
Date: Wed, 11 Sep 2024 09:43:17 -0400 [thread overview]
Message-ID: <20240911094317.4a28fc3b@gandalf.local.home> (raw)
In-Reply-To: <1a3567d5-e558-351a-c45d-73b2e5a8788c@loongson.cn>
On Wed, 11 Sep 2024 14:40:56 +0800
Tiezhu Yang <yangtiezhu@loongson.cn> wrote:
> Hi Masami,
>
> I am a little confused about config UPROBES and UPROBE_EVENTS.
> Uprobes is the user-space counterpart to kprobes, I want to do
> some small changes:
>
> (1) since config KPROBES can be selectable, just make config UPROBES
> selectable too.
>
> (2) since config KPROBE_EVENTS depends on KPROBES rather than select
> KPROBES, just make config UPROBE_EVENTS depends on UPROBES rather
> than select UPROBES.
>
> Could you please let me know are you OK with the following changes?
> If yes, I will send formal patches later.
The difference between uprobes and kprobes is that kprobes can be enabled
inside the kernel outside of kprobe events. Where as, uprobes is only
enabled by uprobe events, so why have the separate option? That is, is
there a reason to enable uprobes without enabling uprobe events?
If you make uprobe events depend on uprobes, that may confuse people about
how to enable uprobe events. Especially since it may break existing configs.
kprobes have been around much longer than kprobe events. That's not the
same with uprobes and uprobe events. They are much more coupled.
-- Steve
next prev parent reply other threads:[~2024-09-11 13:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 6:40 Question about config UPROBES and UPROBE_EVENTS Tiezhu Yang
2024-09-11 13:43 ` Steven Rostedt [this message]
2024-09-29 23:15 ` Masami Hiramatsu
2024-09-30 1:33 ` Tiezhu Yang
2024-09-30 14:06 ` Steven Rostedt
2024-09-30 15:28 ` Masami Hiramatsu
2024-09-30 15:32 ` Steven Rostedt
2024-09-30 15:43 ` Masami Hiramatsu
2024-10-01 6:30 ` Tiezhu Yang
2024-10-01 12:30 ` Steven Rostedt
2024-10-01 12:33 ` Steven Rostedt
2024-10-01 12:32 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240911094317.4a28fc3b@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).