From: Oleg Nesterov <oleg@redhat.com>
To: Jiri Olsa <olsajiri@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
bpf@vger.kernel.org, Martin KaFai Lau <kafai@fb.com>,
Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@chromium.org>,
Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCHv3 1/7] uprobe: Add support for session consumer
Date: Fri, 13 Sep 2024 12:07:49 +0200 [thread overview]
Message-ID: <20240913100749.GB19305@redhat.com> (raw)
In-Reply-To: <ZuP2YFruQDXTRi25@krava>
On 09/13, Jiri Olsa wrote:
>
> On Thu, Sep 12, 2024 at 06:20:29PM +0200, Oleg Nesterov wrote:
> > > +
> > > + if (rc == 0 && uc->ret_handler) {
> >
> > should we enter this block if uc->handler == NULL?
>
> yes, consumer can have just ret_handler defined
Sorry, I meant we do not need to push { cookie, id } into return_instance
if uc->handler == NULL.
And in fact I'd prefer (but won't insist) the new
UPROBE_HANDLER_I_WANT_MY_COOKIE_PLEASE
return code to make this logic more explicit.
Oleg.
next prev parent reply other threads:[~2024-09-13 10:08 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-09 7:45 [PATCHv3 0/7] uprobe, bpf: Add session support Jiri Olsa
2024-09-09 7:45 ` [PATCHv3 1/7] uprobe: Add support for session consumer Jiri Olsa
2024-09-09 23:44 ` Andrii Nakryiko
2024-09-10 7:17 ` Jiri Olsa
2024-09-10 14:10 ` Masami Hiramatsu
2024-09-11 11:48 ` Jiri Olsa
2024-09-12 16:20 ` Oleg Nesterov
2024-09-13 8:22 ` Jiri Olsa
2024-09-13 10:07 ` Oleg Nesterov [this message]
2024-09-13 10:57 ` Oleg Nesterov
2024-09-13 11:34 ` Jiri Olsa
2024-09-13 11:41 ` Oleg Nesterov
2024-09-12 16:35 ` Oleg Nesterov
2024-09-13 8:36 ` Jiri Olsa
2024-09-13 9:32 ` Oleg Nesterov
2024-09-13 10:17 ` Jiri Olsa
2024-09-13 11:52 ` Oleg Nesterov
2024-09-09 7:45 ` [PATCHv3 2/7] bpf: Add support for uprobe multi session attach Jiri Olsa
2024-09-09 23:44 ` Andrii Nakryiko
2024-09-10 7:17 ` Jiri Olsa
2024-09-10 18:09 ` Andrii Nakryiko
2024-09-09 7:45 ` [PATCHv3 3/7] bpf: Add support for uprobe multi session context Jiri Olsa
2024-09-09 7:45 ` [PATCHv3 4/7] libbpf: Add support for uprobe multi session attach Jiri Olsa
2024-09-09 23:44 ` Andrii Nakryiko
2024-09-10 7:17 ` Jiri Olsa
2024-09-09 7:45 ` [PATCHv3 5/7] selftests/bpf: Add uprobe session test Jiri Olsa
2024-09-09 23:45 ` Andrii Nakryiko
2024-09-10 7:17 ` Jiri Olsa
2024-09-09 7:45 ` [PATCHv3 6/7] selftests/bpf: Add uprobe session cookie test Jiri Olsa
2024-09-09 7:45 ` [PATCHv3 7/7] selftests/bpf: Add uprobe session recursive test Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240913100749.GB19305@redhat.com \
--to=oleg@redhat.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=olsajiri@gmail.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sdf@google.com \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).