From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92281129A78; Sat, 14 Sep 2024 21:53:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726350814; cv=none; b=M1+kn88YT7MAvqV8gr97draISwcmEC31lalvNlWoahLKym0j/t8Uoo5EZzgZcK6i/E4RjyRrfIlAqkqlrak7fgEwV2Vyho1yvKQeFAbEdw8vqXq/FHcjqbRYsdZjSgg9GwySI0y496mbcwYIXliH2iRhEv5Ggs/SvEbC9mTc6DE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726350814; c=relaxed/simple; bh=KcvOUuH7U/6mCdw/qFZw6N/Cn5GUTv466T+YcGHTvZw=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=sUu6byQhwwZXjE6VncZMaK2yasnNywmzzLTG8heEHWSsOF/hwnUCNy5DvaKRANujLlATsg4mXpCkI1RRJ+2I5eQejEGwXnH5zOTIXAnEJVuBrvxYFfm9/jig53DQTWduvHa0IYcPPkyHKFAlOKaUsMUuEjj8uLD4Bv+2PTp1OFA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id DCEE5C4CEC0; Sat, 14 Sep 2024 21:53:28 +0000 (UTC) Date: Sat, 14 Sep 2024 17:53:23 -0400 From: Steven Rostedt To: "Masami Hiramatsu (Google)" Cc: Alexei Starovoitov , Florent Revest , linux-trace-kernel@vger.kernel.org, LKML , Martin KaFai Lau , bpf , Sven Schnelle , Alexei Starovoitov , Jiri Olsa , Arnaldo Carvalho de Melo , Daniel Borkmann , Alan Maguire , Mark Rutland , Peter Zijlstra , Thomas Gleixner , Guo Ren , linux-arch@vger.kernel.org Subject: Re: [PATCH v14 19/19] fgraph: Skip recording calltime/rettime if it is not nneeded Message-ID: <20240914175323.16206416@rorschach.local.home> In-Reply-To: <172615389864.133222.14452329708227900626.stgit@devnote2> References: <172615368656.133222.2336770908714920670.stgit@devnote2> <172615389864.133222.14452329708227900626.stgit@devnote2> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, 13 Sep 2024 00:11:38 +0900 "Masami Hiramatsu (Google)" wrote: > From: Masami Hiramatsu (Google) >=20 > Skip recording calltime and rettime if the fgraph_ops does not need it. > This is a kind of performance optimization for fprobe. Since the fprobe > user does not use these entries, recording timestamp in fgraph is just > a overhead (e.g. eBPF, ftrace). So introduce the skip_timestamp flag, > and all fgraph_ops sets this flag, skip recording calltime and rettime. >=20 > Here is the performance results measured by > tools/testing/selftests/bpf/benchs/run_bench_trigger.sh >=20 > Without this: > kprobe-multi : 5.700 =C2=B1 0.065M/s > kretprobe-multi: 4.239 =C2=B1 0.006M/s >=20 > With skip-timestamp: > kprobe-multi : 6.265 =C2=B1 0.033M/s +9.91% > kretprobe-multi: 4.758 =C2=B1 0.009M/s +12.24% >=20 > Suggested-by: Jiri Olsa > Signed-off-by: Masami Hiramatsu (Google) Can you try this series instead: https://lore.kernel.org/all/20240914214805.779822616@goodmis.org/ I rather get rid of the calltime completely from the generic logic, and that series does just that. That series only replaces this patch and can be applied before this series (or after). -- Steve