From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Sami Tolvanen <samitolvanen@google.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Mark Rutland <mark.rutland@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Masahiro Yamada <masahiroy@kernel.org>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/ftrace: Include <asm/ptrace.h>
Date: Tue, 17 Sep 2024 14:17:36 +0900 [thread overview]
Message-ID: <20240917141736.e24ca6004730435676031997@kernel.org> (raw)
In-Reply-To: <20240916221557.846853-2-samitolvanen@google.com>
On Mon, 16 Sep 2024 22:15:57 +0000
Sami Tolvanen <samitolvanen@google.com> wrote:
> <asm/ftrace.h> uses struct pt_regs in several places. Include
> <asm/ptrace.h> to ensure it's visible. This is needed to make sure
> object files that only include <asm/asm-prototypes.h> compile.
Looks good to me.
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Thanks!
>
> Suggested-by: Masahiro Yamada <masahiroy@kernel.org>
> Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
> ---
> arch/x86/include/asm/ftrace.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/x86/include/asm/ftrace.h b/arch/x86/include/asm/ftrace.h
> index 0152a81d9b4a..b4d719de2c84 100644
> --- a/arch/x86/include/asm/ftrace.h
> +++ b/arch/x86/include/asm/ftrace.h
> @@ -2,6 +2,8 @@
> #ifndef _ASM_X86_FTRACE_H
> #define _ASM_X86_FTRACE_H
>
> +#include <asm/ptrace.h>
> +
> #ifdef CONFIG_FUNCTION_TRACER
> #ifndef CC_USING_FENTRY
> # error Compiler does not support fentry?
>
> base-commit: ad060dbbcfcfcba624ef1a75e1d71365a98b86d8
> --
> 2.46.0.662.g92d0881bb0-goog
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
prev parent reply other threads:[~2024-09-17 5:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-16 22:15 [PATCH] x86/ftrace: Include <asm/ptrace.h> Sami Tolvanen
2024-09-17 5:17 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240917141736.e24ca6004730435676031997@kernel.org \
--to=mhiramat@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=masahiroy@kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=samitolvanen@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).