* [PATCH] x86/ftrace: Include <asm/ptrace.h>
@ 2024-09-16 22:15 Sami Tolvanen
2024-09-17 5:17 ` Masami Hiramatsu
0 siblings, 1 reply; 2+ messages in thread
From: Sami Tolvanen @ 2024-09-16 22:15 UTC (permalink / raw)
To: Steven Rostedt, Masami Hiramatsu, Mark Rutland, Thomas Gleixner,
Ingo Molnar, Borislav Petkov, Dave Hansen, x86, H. Peter Anvin
Cc: Sami Tolvanen, Masahiro Yamada, linux-kernel, linux-trace-kernel
<asm/ftrace.h> uses struct pt_regs in several places. Include
<asm/ptrace.h> to ensure it's visible. This is needed to make sure
object files that only include <asm/asm-prototypes.h> compile.
Suggested-by: Masahiro Yamada <masahiroy@kernel.org>
Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
---
arch/x86/include/asm/ftrace.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/x86/include/asm/ftrace.h b/arch/x86/include/asm/ftrace.h
index 0152a81d9b4a..b4d719de2c84 100644
--- a/arch/x86/include/asm/ftrace.h
+++ b/arch/x86/include/asm/ftrace.h
@@ -2,6 +2,8 @@
#ifndef _ASM_X86_FTRACE_H
#define _ASM_X86_FTRACE_H
+#include <asm/ptrace.h>
+
#ifdef CONFIG_FUNCTION_TRACER
#ifndef CC_USING_FENTRY
# error Compiler does not support fentry?
base-commit: ad060dbbcfcfcba624ef1a75e1d71365a98b86d8
--
2.46.0.662.g92d0881bb0-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] x86/ftrace: Include <asm/ptrace.h>
2024-09-16 22:15 [PATCH] x86/ftrace: Include <asm/ptrace.h> Sami Tolvanen
@ 2024-09-17 5:17 ` Masami Hiramatsu
0 siblings, 0 replies; 2+ messages in thread
From: Masami Hiramatsu @ 2024-09-17 5:17 UTC (permalink / raw)
To: Sami Tolvanen
Cc: Steven Rostedt, Mark Rutland, Thomas Gleixner, Ingo Molnar,
Borislav Petkov, Dave Hansen, x86, H. Peter Anvin,
Masahiro Yamada, linux-kernel, linux-trace-kernel
On Mon, 16 Sep 2024 22:15:57 +0000
Sami Tolvanen <samitolvanen@google.com> wrote:
> <asm/ftrace.h> uses struct pt_regs in several places. Include
> <asm/ptrace.h> to ensure it's visible. This is needed to make sure
> object files that only include <asm/asm-prototypes.h> compile.
Looks good to me.
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Thanks!
>
> Suggested-by: Masahiro Yamada <masahiroy@kernel.org>
> Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
> ---
> arch/x86/include/asm/ftrace.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/x86/include/asm/ftrace.h b/arch/x86/include/asm/ftrace.h
> index 0152a81d9b4a..b4d719de2c84 100644
> --- a/arch/x86/include/asm/ftrace.h
> +++ b/arch/x86/include/asm/ftrace.h
> @@ -2,6 +2,8 @@
> #ifndef _ASM_X86_FTRACE_H
> #define _ASM_X86_FTRACE_H
>
> +#include <asm/ptrace.h>
> +
> #ifdef CONFIG_FUNCTION_TRACER
> #ifndef CC_USING_FENTRY
> # error Compiler does not support fentry?
>
> base-commit: ad060dbbcfcfcba624ef1a75e1d71365a98b86d8
> --
> 2.46.0.662.g92d0881bb0-goog
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-17 5:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-16 22:15 [PATCH] x86/ftrace: Include <asm/ptrace.h> Sami Tolvanen
2024-09-17 5:17 ` Masami Hiramatsu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).