* [PATCH] rtla: Fix consistency in getopt_long for timerlat_hist
@ 2024-09-26 14:34 Gabriele Monaco
0 siblings, 0 replies; only message in thread
From: Gabriele Monaco @ 2024-09-26 14:34 UTC (permalink / raw)
To: Steven Rostedt, linux-trace-kernel, linux-kernel
Cc: John Kacur, Luis Goncalves, Tomas Glozar, Gabriele Monaco
Commit e9a4062e1527 ("rtla: Add --trace-buffer-size option") adds a new
long option to rtla utilities, but among all affected files,
timerlat_hist misses a trailing `:` in the corresponding short option
inside the getopt string (e.g. `\3:`). This patch propagates the `:`.
Although this change is not functionally required, it improves
consistency and slightly reduces the likelihood a future change would
introduce a problem.
Signed-off-by: Gabriele Monaco <gmonaco@redhat.com>
---
tools/tracing/rtla/src/timerlat_hist.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/tracing/rtla/src/timerlat_hist.c b/tools/tracing/rtla/src/timerlat_hist.c
index a3907c390d67..1f9137c592f4 100644
--- a/tools/tracing/rtla/src/timerlat_hist.c
+++ b/tools/tracing/rtla/src/timerlat_hist.c
@@ -778,7 +778,7 @@ static struct timerlat_hist_params
/* getopt_long stores the option index here. */
int option_index = 0;
- c = getopt_long(argc, argv, "a:c:C::b:d:e:E:DhH:i:knp:P:s:t::T:uU0123456:7:8:9\1\2:\3",
+ c = getopt_long(argc, argv, "a:c:C::b:d:e:E:DhH:i:knp:P:s:t::T:uU0123456:7:8:9\1\2:\3:",
long_options, &option_index);
/* detect the end of the options. */
base-commit: 11a299a7933e03c83818b431e6a1c53ad387423d
--
2.46.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2024-09-26 14:34 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-26 14:34 [PATCH] rtla: Fix consistency in getopt_long for timerlat_hist Gabriele Monaco
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).