From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50BC8156C6A;
	Tue,  1 Oct 2024 12:32:50 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1727785971; cv=none; b=LS3euBnaIE96EfgRvoscLBLASY+KZ2LPHzWinCyKDKBxNsd0hio41UgCXoxKYrFvmEM8vmFunEcwHLnNIf70yVjzLFUj8Z6zRjvIwjhucTlmJxSgG+wBTmTwI9fIPsgYu+NjhkWGchGONFT9j8zx2GRXJUSicBm5n4vbb65ZzjM=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1727785971; c=relaxed/simple;
	bh=DGbX1ZbsnhlL6zqk1rlga8QyOPbbUd7y07TXI/tvErI=;
	h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:
	 MIME-Version:Content-Type; b=KzJjoulQjBKT0C4PdZd0BZx92PkqBGid1wB7E/pIdEjYlmKdD0REb4Ls22kdjwbp1o47jcmirHFclGV6fo09+XDygeoi0+gIgj7pXfn57TCa4RvfB/wND1hvtKCtRu+3YNyATFPMPsxeNWfhW/Hf5p1SqpDbxVsagG+JJlCn1Ag=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4E751C4CEC6;
	Tue,  1 Oct 2024 12:32:50 +0000 (UTC)
Date: Tue, 1 Oct 2024 08:33:39 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Tiezhu Yang <yangtiezhu@loongson.cn>
Cc: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
 linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Question about config UPROBES and UPROBE_EVENTS
Message-ID: <20241001083339.612395ba@gandalf.local.home>
In-Reply-To: <20241001083042.12f388e7@gandalf.local.home>
References: <1a3567d5-e558-351a-c45d-73b2e5a8788c@loongson.cn>
	<20240930081529.f6f9161c20db9b95c9b46252@kernel.org>
	<f639079e-bc1c-7f2a-4c3f-de1a6780da84@loongson.cn>
	<20240930100630.7894c442@gandalf.local.home>
	<20241001002813.6012587b5e52737a576f1d0b@kernel.org>
	<20240930113231.6c87108d@gandalf.local.home>
	<20241001004307.bc238bbda81907c08a8c1e96@kernel.org>
	<10d33d7f-5785-93e1-128d-5ad6ac2e771f@loongson.cn>
	<20241001083042.12f388e7@gandalf.local.home>
X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu)
Precedence: bulk
X-Mailing-List: linux-trace-kernel@vger.kernel.org
List-Id: <linux-trace-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-trace-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-trace-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 1 Oct 2024 08:30:42 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Tue, 1 Oct 2024 14:30:33 +0800
> Tiezhu Yang <yangtiezhu@loongson.cn> wrote:
> 
> > Then, CONFIG_KPROBE_EVENTS should depend on or select CONFIG_KPROBES?
> > In the current code, CONFIG_KPROBE_EVENTS depend on CONFIG_KPROBES,
> > the CONFIG_KPROBE_EVENTS menu is hidden if CONFIG_KPROBES is not set.  
> 
> We could just for consistency. KPROBE_EVENTS would then need to depend on
> HAVE_KPROBES as well. It does add some duplication.
>

I take this back. I don't think there's any reason to have a UPROBES prompt.

If you want UPROBES, you should have UPROBE_EVENTS. They are completely
different than kprobes.

-- Steve