From: Steven Rostedt <rostedt@goodmis.org>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Alexei Starovoitov <ast@kernel.org>, Yonghong Song <yhs@fb.com>,
"Paul E . McKenney" <paulmck@kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>,
Andrii Nakryiko <andrii.nakryiko@gmail.com>,
bpf@vger.kernel.org, Joel Fernandes <joel@joelfernandes.org>,
linux-trace-kernel@vger.kernel.org,
Michael Jeanson <mjeanson@efficios.com>
Subject: Re: [PATCH v3 2/8] tracing/ftrace: guard syscall probe with preempt_notrace
Date: Tue, 8 Oct 2024 19:19:57 -0400 [thread overview]
Message-ID: <20241008191957.6cb66fa2@gandalf.local.home> (raw)
In-Reply-To: <20241004145818.1726671-3-mathieu.desnoyers@efficios.com>
On Fri, 4 Oct 2024 10:58:12 -0400
Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:
> + PARAMS(assign), PARAMS(print)) \
> +static notrace void \
> +trace_event_raw_event_##call(void *__data, proto) \
> +{ \
> + guard(preempt_notrace)(); \
> + do_trace_event_raw_event_##call(__data, args); \
> +}
> +
Do we really need to use "guard()" for a single line function? Why make the
compiler do more work?
static notrace void \
trace_event_raw_event_##call(void *__data, proto) \
{ \
preempt_disable_notrace(); \
do_trace_event_raw_event_##call(__data, args); \
preempt_enable_notrace(); \
}
Is more readable.
-- Steve
next prev parent reply other threads:[~2024-10-08 23:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 14:58 [PATCH v3 0/8] tracing: Allow system call tracepoints to handle page faults Mathieu Desnoyers
2024-10-04 14:58 ` [PATCH v3 1/8] tracing: Declare system call tracepoints with TRACE_EVENT_SYSCALL Mathieu Desnoyers
2024-10-04 14:58 ` [PATCH v3 2/8] tracing/ftrace: guard syscall probe with preempt_notrace Mathieu Desnoyers
2024-10-08 23:19 ` Steven Rostedt [this message]
2024-10-09 0:49 ` Mathieu Desnoyers
2024-10-04 14:58 ` [PATCH v3 3/8] tracing/perf: " Mathieu Desnoyers
2024-10-08 23:21 ` Steven Rostedt
2024-10-04 14:58 ` [PATCH v3 4/8] tracing/bpf: " Mathieu Desnoyers
2024-10-08 23:22 ` Steven Rostedt
2024-10-04 14:58 ` [PATCH v3 5/8] tracing: Allow system call tracepoints to handle page faults Mathieu Desnoyers
2024-10-08 23:23 ` Steven Rostedt
2024-10-09 0:56 ` Mathieu Desnoyers
2024-10-04 14:58 ` [PATCH v3 6/8] tracing/ftrace: Add might_fault check to syscall probes Mathieu Desnoyers
2024-10-04 14:58 ` [PATCH v3 7/8] tracing/perf: " Mathieu Desnoyers
2024-10-04 14:58 ` [PATCH v3 8/8] tracing/bpf: " Mathieu Desnoyers
2024-10-08 23:33 ` [PATCH v3 0/8] tracing: Allow system call tracepoints to handle page faults Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241008191957.6cb66fa2@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andrii.nakryiko@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=mjeanson@efficios.com \
--cc=namhyung@kernel.org \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox