From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 462E519DFA2; Thu, 10 Oct 2024 19:43:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728589398; cv=none; b=RbKJIIJrImwLHbsW9W7sptmuushVTafakYTg+mowz9ziLjkZyQsRjlAtbr7k6BafHfgc+mOheefEuL4CSTwzEPShkB8//MKS/6+q9xbHKiEoKSZjRdrAmNNhBtStj4TPdge2HIe9hFXIn7X+JoCLcEKi0NoMBIaFSq9C+vgYDj8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728589398; c=relaxed/simple; bh=Q7OewBtQ0Gea+BFYlkHx/5aubBH7TAKhTSr3FH3BPqA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=MdcRwGCEMAoH9yewKKwFBpJCOPuGGXNwuCBT/Q85b3WNaAonKJls/5CKNybxP2QRrRTEP7CT27vf5VG1vossmmzlk2gkDek9ZRSolokc3w80oUOcbZlyTgVHWPsvDN+FyeDE+Beb/Rqao3LoD9Lky8AyUaUm6iMzIeSIQEJ3WSY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75495C4CECF; Thu, 10 Oct 2024 19:43:12 +0000 (UTC) Date: Thu, 10 Oct 2024 15:43:20 -0400 From: Steven Rostedt To: Josh Poimboeuf Cc: Alice Ryhl , Masami Hiramatsu , Mathieu Desnoyers , Peter Zijlstra , Jason Baron , Ard Biesheuvel , Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?UTF-8?B?Qmo=?= =?UTF-8?B?w7Zybg==?= Roy Baron , Benno Lossin , Andreas Hindborg , linux-trace-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann , linux-arch@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Sean Christopherson , Uros Bizjak , Catalin Marinas , Will Deacon , Marc Zyngier , Oliver Upton , Mark Rutland , Ryan Roberts , Fuad Tabba , linux-arm-kernel@lists.infradead.org, Paul Walmsley , Palmer Dabbelt , Albert Ou , Anup Patel , Andrew Jones , Alexandre Ghiti , Conor Dooley , Samuel Holland , linux-riscv@lists.infradead.org, Huacai Chen , WANG Xuerui , Bibo Mao , Tiezhu Yang , Andrew Morton , Tianrui Zhao , loongarch@lists.linux.dev Subject: Re: [PATCH v9 1/5] rust: add generic static_key_false Message-ID: <20241010154320.6d17ba69@gandalf.local.home> In-Reply-To: <20241001211543.qdjl4pyfhehxqfk7@treble> References: <20241001-tracepoint-v9-0-1ad3b7d78acb@google.com> <20241001-tracepoint-v9-1-1ad3b7d78acb@google.com> <20241001211543.qdjl4pyfhehxqfk7@treble> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 1 Oct 2024 14:15:43 -0700 Josh Poimboeuf wrote: > On Tue, Oct 01, 2024 at 01:29:58PM +0000, Alice Ryhl wrote: > > Add just enough support for static key so that we can use it from > > tracepoints. Tracepoints rely on `static_key_false` even though it is > > deprecated, so we add the same functionality to Rust. > > Instead of extending the old deprecated static key interface into Rust, > can we just change tracepoints to use the new one? > > /me makes a note to go convert the other users... > > From: Josh Poimboeuf > Subject: [PATCH] tracepoints: Use new static branch API > > The old static key API based on 'struct static_key' is deprecated. > Convert tracepoints to use the new API. > > Signed-off-by: Josh Poimboeuf Alice, Can you send a v10 with the added acks and whitespace fixes as well as using static_branch_unlikely(), and I'll pull it into my tree. Base it off of v6.12-rc2. Thanks, -- Steve