Linux Trace Kernel
 help / color / mirror / Atom feed
From: Josh Poimboeuf <jpoimboe@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	linux-kernel@vger.kernel.org,
	Sven Schnelle <svens@stackframe.org>,
	linux-trace-kernel@vger.kernel.org, linux-parisc@vger.kernel.org,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] parisc/ftrace: Fix function graph tracing disablement
Date: Thu, 10 Oct 2024 12:56:10 -0700	[thread overview]
Message-ID: <20241010195610.25mraxgovi4vowo2@treble> (raw)
In-Reply-To: <20241010154840.6e158c78@gandalf.local.home>

On Thu, Oct 10, 2024 at 03:48:40PM -0400, Steven Rostedt wrote:
> > +++ b/arch/parisc/kernel/ftrace.c
> > @@ -87,7 +87,7 @@ int ftrace_enable_ftrace_graph_caller(void)
> >  
> >  int ftrace_disable_ftrace_graph_caller(void)
> >  {
> > -	static_key_enable(&ftrace_graph_enable.key);
> > +	static_key_disable(&ftrace_graph_enable.key);
> >  	return 0;
> >  }
> >  #endif
> 
> Awfully quite :-/
> 
> I wonder if anyone cares about parisc today?
> 
> Hmm.

I still see some git activity in arch/parisc, so apparently so...

I only stumbled on this by accident (code inspection) while making
another unrelated change.

-- 
Josh

  reply	other threads:[~2024-10-10 19:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-02 21:32 [PATCH] parisc/ftrace: Fix function graph tracing disablement Josh Poimboeuf
2024-10-10 19:48 ` Steven Rostedt
2024-10-10 19:56   ` Josh Poimboeuf [this message]
2024-10-10 20:25     ` Helge Deller
2024-10-10 20:33       ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241010195610.25mraxgovi4vowo2@treble \
    --to=jpoimboe@kernel.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=deller@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mhiramat@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=svens@stackframe.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox