linux-trace-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@kernel.org>
To: Oleg Nesterov <oleg@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Andrii Nakryiko <andrii@kernel.org>
Cc: bpf@vger.kernel.org, Martin KaFai Lau <kafai@fb.com>,
	Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
	John Fastabend <john.fastabend@gmail.com>,
	KP Singh <kpsingh@chromium.org>,
	Stanislav Fomichev <sdf@fomichev.me>, Hao Luo <haoluo@google.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: [PATCHv8 bpf-next 01/13] bpf: Allow return values 0 and 1 for kprobe session
Date: Fri, 18 Oct 2024 22:40:57 +0200	[thread overview]
Message-ID: <20241018204109.713820-2-jolsa@kernel.org> (raw)
In-Reply-To: <20241018204109.713820-1-jolsa@kernel.org>

The kprobe session program can return only 0 or 1,
instruct verifier to check for that.

Fixes: 535a3692ba72 ("bpf: Add support for kprobe session attach")
Acked-by: Andrii Nakryiko <andrii@kernel.org>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
 kernel/bpf/verifier.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
index f514247ba8ba..5c941fd1b141 100644
--- a/kernel/bpf/verifier.c
+++ b/kernel/bpf/verifier.c
@@ -15915,6 +15915,15 @@ static int check_return_code(struct bpf_verifier_env *env, int regno, const char
 			return -ENOTSUPP;
 		}
 		break;
+	case BPF_PROG_TYPE_KPROBE:
+		switch (env->prog->expected_attach_type) {
+		case BPF_TRACE_KPROBE_SESSION:
+			range = retval_range(0, 1);
+			break;
+		default:
+			return 0;
+		}
+		break;
 	case BPF_PROG_TYPE_SK_LOOKUP:
 		range = retval_range(SK_DROP, SK_PASS);
 		break;
-- 
2.46.2


  reply	other threads:[~2024-10-18 20:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-18 20:40 [PATCHv8 bpf-next 00/13] bpf: Add uprobe session support Jiri Olsa
2024-10-18 20:40 ` Jiri Olsa [this message]
2024-10-18 20:40 ` [PATCHv8 bpf-next 02/13] bpf: Force uprobe bpf program to always return 0 Jiri Olsa
2024-10-18 20:40 ` [PATCHv8 bpf-next 03/13] bpf: Add support for uprobe multi session attach Jiri Olsa
2024-10-18 20:41 ` [PATCHv8 bpf-next 04/13] bpf: Add support for uprobe multi session context Jiri Olsa
2024-10-18 20:41 ` [PATCHv8 bpf-next 05/13] libbpf: Add support for uprobe multi session attach Jiri Olsa
2024-10-18 20:41 ` [PATCHv8 bpf-next 06/13] selftests/bpf: Add uprobe session test Jiri Olsa
2024-10-18 20:41 ` [PATCHv8 bpf-next 07/13] selftests/bpf: Add uprobe session cookie test Jiri Olsa
2024-10-18 20:41 ` [PATCHv8 bpf-next 08/13] selftests/bpf: Add uprobe session recursive test Jiri Olsa
2024-10-18 20:41 ` [PATCHv8 bpf-next 09/13] selftests/bpf: Add uprobe session verifier test for return value Jiri Olsa
2024-10-18 20:41 ` [PATCHv8 bpf-next 10/13] selftests/bpf: Add kprobe " Jiri Olsa
2024-10-18 20:41 ` [PATCHv8 bpf-next 11/13] selftests/bpf: Add uprobe session single consumer test Jiri Olsa
2024-10-18 20:41 ` [PATCHv8 bpf-next 12/13] selftests/bpf: Add uprobe sessions to " Jiri Olsa
2024-10-18 20:41 ` [PATCHv8 bpf-next 13/13] selftests/bpf: Add threads " Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241018204109.713820-2-jolsa@kernel.org \
    --to=jolsa@kernel.org \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=haoluo@google.com \
    --cc=john.fastabend@gmail.com \
    --cc=kafai@fb.com \
    --cc=kpsingh@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=oleg@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=sdf@fomichev.me \
    --cc=songliubraving@fb.com \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).