From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80B4F1C330C; Mon, 21 Oct 2024 17:01:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729530090; cv=none; b=U0CJgLAsgoEDABlZqhvpkrCq+Kj301vFQLiXuGdcFiQXs3eEfxuCRN8Om8oWd/EMJNAqJYv6S7kld2ayzga4T5DLwHqNWWGe0JSBoIHgEG7B33pW7e88CMGgKP8m2SOoWCfMpzcH/G6h6D2misaDlViGx24py65SBqavlboFBTg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729530090; c=relaxed/simple; bh=ykBAlA5lF/Xip95YGx6pvzf/iefPqGDL1Qm98SfmVio=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Pfk9t8GKcdFyJpxHHzmxE/jaCDNFA6Izspzmf61YEKtUnNVJiBt3pWFwBWU/ZuCth/oaRyVJT9K1aDhuBhSnVSX9NWTnVFll6m8yCcKndunZaKwhx0jmy5OV59HVd0eHxIpoakqXVXOzUfQrHOC0y9q9tdWjKwH0K8wCuBthJwY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=uc5T0c5o; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uc5T0c5o" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4CF69C4CEC3; Mon, 21 Oct 2024 17:01:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729530090; bh=ykBAlA5lF/Xip95YGx6pvzf/iefPqGDL1Qm98SfmVio=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uc5T0c5oIDl+NEZXEJV+MK8MYSXdzj965ZqjZbtRyjuOzq/QXX5tN0UDajUsCH5tx 5+PL13v0aHtQC1cJ/zpC4pTYZIg8kdti50Uv1XUSC5G5Ubt+cKUeVB9i/xVzO6IX90 8zBNoYPovc4LbFTKzsEZNk+S0DIkaPqGAe62SS7pS5dlhPHoh6lGWLM78/RsYNsSh0 nTsnAbjMZAPIbgzd7fY/Tfi/jlfdFbc+pggQFVra+ZFWiTsn+95KNUkGeILuh7GoP0 p4sd3gxB0Y4AidJUzGmzVXNwOxUYSXtdLly3TTWO3fFyhrDPVngYBPTe5hbIAApTo3 SnEOZkeZ3/DHg== Date: Mon, 21 Oct 2024 18:01:21 +0100 From: Will Deacon To: "Masami Hiramatsu (Google)" Cc: Alexei Starovoitov , Steven Rostedt , Florent Revest , linux-trace-kernel@vger.kernel.org, LKML , Martin KaFai Lau , bpf , Alexei Starovoitov , Jiri Olsa , Alan Maguire , Mark Rutland , linux-arch@vger.kernel.org, Catalin Marinas , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" Subject: Re: [PATCH v17 07/16] tracing: Add ftrace_fill_perf_regs() for perf event Message-ID: <20241021170121.GA26122@willie-the-truck> References: <172904026427.36809.516716204730117800.stgit@devnote2> <172904035199.36809.9900108557809424653.stgit@devnote2> Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <172904035199.36809.9900108557809424653.stgit@devnote2> User-Agent: Mutt/1.10.1 (2018-07-13) On Wed, Oct 16, 2024 at 09:59:12AM +0900, Masami Hiramatsu (Google) wrote: > From: Masami Hiramatsu (Google) > > Add ftrace_fill_perf_regs() which should be compatible with the > perf_fetch_caller_regs(). In other words, the pt_regs returned from the > ftrace_fill_perf_regs() must satisfy 'user_mode(regs) == false' and can be > used for stack tracing. > > Signed-off-by: Masami Hiramatsu (Google) > Cc: Steven Rostedt > Cc: Mark Rutland > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Michael Ellerman > Cc: Nicholas Piggin > Cc: Christophe Leroy > Cc: Naveen N Rao > Cc: Madhavan Srinivasan > Cc: Heiko Carstens > Cc: Vasily Gorbik > Cc: Alexander Gordeev > Cc: Christian Borntraeger > Cc: Sven Schnelle > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: Dave Hansen > Cc: x86@kernel.org > Cc: "H. Peter Anvin" > > --- > Changes in v16: > - Fix s390 to clear psw.mask according to Heiko's suggestion. > --- > arch/arm64/include/asm/ftrace.h | 7 +++++++ > arch/powerpc/include/asm/ftrace.h | 7 +++++++ > arch/s390/include/asm/ftrace.h | 6 ++++++ > arch/x86/include/asm/ftrace.h | 7 +++++++ > include/linux/ftrace.h | 31 +++++++++++++++++++++++++++++++ > 5 files changed, 58 insertions(+) > > diff --git a/arch/arm64/include/asm/ftrace.h b/arch/arm64/include/asm/ftrace.h > index d344c69eb01e..6493a575664f 100644 > --- a/arch/arm64/include/asm/ftrace.h > +++ b/arch/arm64/include/asm/ftrace.h > @@ -146,6 +146,13 @@ ftrace_partial_regs(const struct ftrace_regs *fregs, struct pt_regs *regs) > return regs; > } > > +#define arch_ftrace_fill_perf_regs(fregs, _regs) do { \ > + (_regs)->pc = arch_ftrace_regs(fregs)->pc; \ > + (_regs)->regs[29] = arch_ftrace_regs(fregs)->fp; \ > + (_regs)->sp = arch_ftrace_regs(fregs)->sp; \ > + (_regs)->pstate = PSR_MODE_EL1h; \ > + } while (0) arm64 bit looks correct to me: Acked-by: Will Deacon Will