From: Steven Rostedt <rostedt@goodmis.org>
To: Sean Anderson <sean.anderson@linux.dev>
Cc: Christoph Hellwig <hch@lst.de>,
iommu@lists.linux.dev, Robin Murphy <robin.murphy@arm.com>,
linux-trace-kernel@vger.kernel.org,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] dma-mapping: Use trace_dma_alloc for dma_alloc* instead of using trace_dma_map
Date: Thu, 24 Oct 2024 22:19:55 -0400 [thread overview]
Message-ID: <20241024221955.2fd9356e@rorschach.local.home> (raw)
In-Reply-To: <20241018150036.2878190-4-sean.anderson@linux.dev>
On Fri, 18 Oct 2024 11:00:36 -0400
Sean Anderson <sean.anderson@linux.dev> wrote:
> + TP_printk("%s dir=%s dma_addr=%llx size=%zu phys_addrs=%s flags=%s attrs=%s",
> + __get_str(device),
> + decode_dma_data_direction(__entry->dir),
> + __entry->dma_addr,
> + __entry->size,
> + __print_array(__get_dynamic_array(phys_addrs),
> + __get_dynamic_array_len(phys_addrs) /
> + sizeof(u64), sizeof(u64)),
> + show_gfp_flags(__entry->flags),
> + decode_dma_attrs(__entry->attrs))
From a tracing perspective, everything in the patch set looks good.
Just a heads up that the above __print_array() should be changed after
6.13 is out to use __print_dynamic_array().
https://lore.kernel.org/linux-trace-kernel/20241022194158.110073-3-avadhut.naik@amd.com/
For the series:
Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
-- Steve
next prev parent reply other threads:[~2024-10-25 2:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 15:00 [PATCH v2 0/4] dma-mapping: Trace more error paths Sean Anderson
2024-10-18 15:00 ` [PATCH v2 1/4] dma-mapping: Use macros to define events in a class Sean Anderson
2024-10-18 15:00 ` [PATCH v2 2/4] dma-mapping: Trace dma_alloc/free direction Sean Anderson
2024-10-18 15:00 ` [PATCH v2 3/4] dma-mapping: Use trace_dma_alloc for dma_alloc* instead of using trace_dma_map Sean Anderson
2024-10-25 2:19 ` Steven Rostedt [this message]
2024-10-18 15:00 ` [PATCH v2 4/4] dma-mapping: Trace more error paths Sean Anderson
2024-10-23 5:30 ` [PATCH v2 0/4] " Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241024221955.2fd9356e@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=hch@lst.de \
--cc=iommu@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=robin.murphy@arm.com \
--cc=sean.anderson@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).