From: Kalesh Singh <kaleshsingh@google.com>
To: dhowells@redhat.com, rostedt@goodmis.org, mhiramat@kernel.org
Cc: surenb@google.com, jyescas@google.com, kernel-team@android.com,
android-mm@google.com, Kalesh Singh <kaleshsingh@google.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Shuah Khan <shuah@kernel.org>, Ali Zahraee <ahzahraee@gmail.com>,
Christian Brauner <brauner@kernel.org>,
Eric Sandeen <sandeen@redhat.com>,
linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: [PATCH 1/3] tracing: Document tracefs gid mount option
Date: Mon, 28 Oct 2024 14:43:57 -0700 [thread overview]
Message-ID: <20241028214550.2099923-2-kaleshsingh@google.com> (raw)
In-Reply-To: <20241028214550.2099923-1-kaleshsingh@google.com>
[1] and [2] introduced a new gid mount options that could apply to a
group to all entries in tracefs.
Document this in the tracing readme.
[1] https://lore.kernel.org/r/20211208075720.4855d180@gandalf.local.home/T/#u
[2] https://lore.kernel.org/r/20211207171729.2a54e1b3@gandalf.local.home/T/#u
Cc: David Howells <dhowells@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Signed-off-by: Kalesh Singh <kaleshsingh@google.com>
---
kernel/trace/trace.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index a8f52b6527ca..2b64b3ec67d9 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -5501,6 +5501,10 @@ static const struct file_operations tracing_iter_fops = {
static const char readme_msg[] =
"tracing mini-HOWTO:\n\n"
+ "By default tracefs removes all OTH file permission bits.\n"
+ "When mounting tracefs an optional group id can be specified\n"
+ "which adds the group to every directory and file in tracefs:\n\n"
+ "\t e.g. mount -t tracefs [-o [gid=<gid>]] nodev /sys/kernel/tracing\n\n"
"# echo 0 > tracing_on : quick way to disable tracing\n"
"# echo 1 > tracing_on : quick way to re-enable tracing\n\n"
" Important files:\n"
--
2.47.0.163.g1226f6d8fa-goog
next prev parent reply other threads:[~2024-10-28 22:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 21:43 [PATCH 0/3] Tracefs gid mount option fixes Kalesh Singh
2024-10-28 21:43 ` Kalesh Singh [this message]
2024-10-28 23:12 ` [PATCH 1/3] tracing: Document tracefs gid mount option Steven Rostedt
2024-10-28 21:43 ` [PATCH 2/3] tracing/selftests: Add tracefs mount options test Kalesh Singh
2024-10-28 23:14 ` Steven Rostedt
2024-10-28 23:23 ` Kalesh Singh
2024-10-30 17:24 ` Kalesh Singh
2024-10-28 21:43 ` [PATCH 3/3] tracing: Fix tracefs gid mount option Kalesh Singh
2024-10-29 3:00 ` Eric Sandeen
2024-10-29 21:33 ` Kalesh Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241028214550.2099923-2-kaleshsingh@google.com \
--to=kaleshsingh@google.com \
--cc=ahzahraee@gmail.com \
--cc=android-mm@google.com \
--cc=brauner@kernel.org \
--cc=dhowells@redhat.com \
--cc=jyescas@google.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=sandeen@redhat.com \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox