From: Steven Rostedt <rostedt@goodmis.org>
To: Ryan Roberts <ryan.roberts@arm.com>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH v2] tracing: Make percpu stack trace buffer invariant to PAGE_SIZE
Date: Wed, 30 Oct 2024 17:15:32 -0400 [thread overview]
Message-ID: <20241030171532.7ed01770@rorschach.local.home> (raw)
In-Reply-To: <42f825a2-ceb6-488a-8c63-fcc879cce096@arm.com>
On Wed, 30 Oct 2024 08:50:16 +0000
Ryan Roberts <ryan.roberts@arm.com> wrote:
> On 21/10/2024 15:18, Ryan Roberts wrote:
> > Previously the size of "struct ftrace_stacks" depended upon PAGE_SIZE.
> > For the common 4K page size, on a 64-bit system, sizeof(struct
> > ftrace_stacks) was 32K. But for a 64K page size, sizeof(struct
> > ftrace_stacks) was 512K.
> >
> > But ftrace stack usage requirements should be invariant to page size. So
> > let's redefine FTRACE_KSTACK_ENTRIES so that "struct ftrace_stacks" is
> > always sized at 32K for 64-bit and 16K for 32-bit.
> >
> > As a side effect, it removes the PAGE_SIZE compile-time constant
> > assumption from this code, which is required to reach the goal of
> > boot-time page size selection.
>
> Just a polite bump on this... Does anyone have any comments?
No, it's in my queue. I've just been traveling.
-- Steve
prev parent reply other threads:[~2024-10-30 21:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 14:18 [PATCH v2] tracing: Make percpu stack trace buffer invariant to PAGE_SIZE Ryan Roberts
2024-10-30 8:50 ` Ryan Roberts
2024-10-30 21:15 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241030171532.7ed01770@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=ryan.roberts@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox