From: Steven Rostedt <rostedt@goodmis.org>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Jinjie Ruan <ruanjinjie@huawei.com>,
mhiramat@kernel.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH v2] tracing: Replace strncpy() with strscpy() when copying comm
Date: Thu, 31 Oct 2024 11:48:38 -0400 [thread overview]
Message-ID: <20241031114838.02b404ba@gandalf.local.home> (raw)
In-Reply-To: <af478335-d0ad-40d8-a827-eeb06c1f4e70@efficios.com>
On Thu, 31 Oct 2024 11:12:06 -0400
Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:
> > --- a/kernel/trace/trace.c
> > +++ b/kernel/trace/trace.c
> > @@ -1934,7 +1934,7 @@ __update_max_tr(struct trace_array *tr, struct task_struct *tsk, int cpu)
> > max_data->critical_start = data->critical_start;
> > max_data->critical_end = data->critical_end;
> >
> > - strncpy(max_data->comm, tsk->comm, TASK_COMM_LEN);
> > + strscpy(max_data->comm, tsk->comm);
>
> make allyesconfig + make please ?
Or at a minimum, make sure all the code you change is compiled.
-- Steve
next prev parent reply other threads:[~2024-10-31 15:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-31 12:01 [PATCH v2] tracing: Replace strncpy() with strscpy() when copying comm Jinjie Ruan
2024-10-31 15:12 ` Mathieu Desnoyers
2024-10-31 15:48 ` Steven Rostedt [this message]
2024-11-01 1:45 ` Jinjie Ruan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241031114838.02b404ba@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=ruanjinjie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox