From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B70A11A7060; Fri, 1 Nov 2024 14:21:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730470878; cv=none; b=q6ozqGPyIL/yESx5nEVNwQmp9GtHqVzUAbcp7Yyx6BqSKoVhwI323TtW2h/TIwafd2to1GvU7GgLuGx7KEbLyl1BcT70DREOQJthECQLPxj6lUzaFTJQcAr9dqnSwoUPMn5MDbjmFfhlAHaFwZJRVRvtUokBj0CxdkaaY3NtlD8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730470878; c=relaxed/simple; bh=S7KBA8xEO6BpAvteapa4TKEuJiHMXUfN+fW77Vcz0uU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=i9ymUTkRzeSTYhUkPdLoxtO8b2wpibf2IyTN3mcBIxauyAhHc3PVgEqC6PNgB3a80LGgDcB3imxSILf8d5aS0ylDAGInZ+Bn0MLBL+Zq8hbOlKdRlVGB2nNFYEa5irzUZX6dwY+LxMf1pBS+1gnZHKRgGegVEr1qTGe8VUQyVTQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5CDAFC4CECD; Fri, 1 Nov 2024 14:21:14 +0000 (UTC) Date: Fri, 1 Nov 2024 10:22:12 -0400 From: Steven Rostedt To: "Masami Hiramatsu (Google)" Cc: Alexei Starovoitov , Florent Revest , linux-trace-kernel@vger.kernel.org, LKML , Martin KaFai Lau , bpf , Alexei Starovoitov , Jiri Olsa , Alan Maguire , Mark Rutland , linux-arch@vger.kernel.org, Catalin Marinas , Will Deacon , Huacai Chen , WANG Xuerui , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Arnd Bergmann , Mathieu Desnoyers Subject: Re: [PATCH v18 12/17] fprobe: Add fprobe_header encoding feature Message-ID: <20241101102212.5e9d74d9@gandalf.local.home> In-Reply-To: <172991747946.443985.11014834036464028393.stgit@devnote2> References: <172991731968.443985.4558065903004844780.stgit@devnote2> <172991747946.443985.11014834036464028393.stgit@devnote2> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 26 Oct 2024 13:37:59 +0900 "Masami Hiramatsu (Google)" wrote: > From: Masami Hiramatsu (Google) > > Fprobe store its data structure address and size on the fgraph return stack > by __fprobe_header. But most 64bit architecture can combine those to > one unsigned long value because 4 MSB in the kernel address are the same. > With this encoding, fprobe can consume less space on ret_stack. > > This introduces asm/fprobe.h to define arch dependent encode/decode > macros. Note that since fprobe depends on CONFIG_HAVE_FUNCTION_GRAPH_FREGS, > currently only arm64, loongarch, riscv, s390 and x86 are supported. > > Signed-off-by: Masami Hiramatsu (Google) > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Huacai Chen > Cc: WANG Xuerui > Cc: Paul Walmsley > Cc: Palmer Dabbelt > Cc: Albert Ou > Cc: Heiko Carstens > Cc: Vasily Gorbik > Cc: Alexander Gordeev > Cc: Christian Borntraeger > Cc: Sven Schnelle > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: Dave Hansen > Cc: x86@kernel.org > Cc: "H. Peter Anvin" > Cc: Arnd Bergmann > Cc: Steven Rostedt > Cc: Masami Hiramatsu > Cc: Mathieu Desnoyers > --- > arch/arm64/include/asm/fprobe.h | 7 +++++++ > arch/loongarch/include/asm/fprobe.h | 5 +++++ > arch/riscv/include/asm/fprobe.h | 9 +++++++++ > arch/s390/include/asm/fprobe.h | 10 ++++++++++ > arch/x86/include/asm/fprobe.h | 9 +++++++++ > include/asm-generic/fprobe.h | 33 +++++++++++++++++++++++++++++++++ > kernel/trace/fprobe.c | 29 +++++++++++++++++++++++++++++ > 7 files changed, 102 insertions(+) > create mode 100644 arch/arm64/include/asm/fprobe.h > create mode 100644 arch/loongarch/include/asm/fprobe.h > create mode 100644 arch/riscv/include/asm/fprobe.h > create mode 100644 arch/s390/include/asm/fprobe.h > create mode 100644 arch/x86/include/asm/fprobe.h > create mode 100644 include/asm-generic/fprobe.h > > diff --git a/arch/arm64/include/asm/fprobe.h b/arch/arm64/include/asm/fprobe.h > new file mode 100644 > index 000000000000..bbf254db878d > --- /dev/null > +++ b/arch/arm64/include/asm/fprobe.h > @@ -0,0 +1,7 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#ifndef _ASM_ARM64_FPROBE_H > +#define _ASM_ARM64_FPROBE_H > + > +#include > + > +#endif /* _ASM_ARM64_FPROBE_H */ > \ No newline at end of file This isn't the way to add asm-generic code to architectures. It needs to be in the Kbuild file. Like this: diff --git a/arch/arm64/include/asm/Kbuild b/arch/arm64/include/asm/Kbuild index 4e350df9a02d..0d0a638d41a8 100644 --- a/arch/arm64/include/asm/Kbuild +++ b/arch/arm64/include/asm/Kbuild @@ -14,6 +14,7 @@ generic-y += qrwlock.h generic-y += qspinlock.h generic-y += parport.h generic-y += user.h +generic-y += fprobe.h generated-y += cpucap-defs.h generated-y += sysreg-defs.h > diff --git a/arch/loongarch/include/asm/fprobe.h b/arch/loongarch/include/asm/fprobe.h > new file mode 100644 > index 000000000000..68156a66873c > --- /dev/null > +++ b/arch/loongarch/include/asm/fprobe.h > @@ -0,0 +1,5 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#ifndef _ASM_LOONGARCH_FPROBE_H > +#define _ASM_LOONGARCH_FPROBE_H > + > +#endif /* _ASM_LOONGARCH_FPROBE_H */ > \ No newline at end of file > diff --git a/arch/riscv/include/asm/fprobe.h b/arch/riscv/include/asm/fprobe.h > new file mode 100644 > index 000000000000..51fc2ef3eda1 > --- /dev/null > +++ b/arch/riscv/include/asm/fprobe.h > @@ -0,0 +1,9 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#ifndef _ASM_RISCV_FPROBE_H > +#define _ASM_RISCV_FPROBE_H > + > +#ifdef CONFIG_64BIT > +#include > +#endif > + > +#endif /* _ASM_RISCV_FPROBE_H */ > \ No newline at end of file > diff --git a/arch/s390/include/asm/fprobe.h b/arch/s390/include/asm/fprobe.h > new file mode 100644 > index 000000000000..84b94ba6e3a4 > --- /dev/null > +++ b/arch/s390/include/asm/fprobe.h > @@ -0,0 +1,10 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#ifndef _ASM_S390_FPROBE_H > +#define _ASM_S390_FPROBE_H > + > +#include > + > +#undef FPROBE_HEADER_MSB_PATTERN > +#define FPROBE_HEADER_MSB_PATTERN 0 > + > +#endif /* _ASM_S390_FPROBE_H */ > \ No newline at end of file > diff --git a/arch/x86/include/asm/fprobe.h b/arch/x86/include/asm/fprobe.h > new file mode 100644 > index 000000000000..c863518bef90 > --- /dev/null > +++ b/arch/x86/include/asm/fprobe.h > @@ -0,0 +1,9 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#ifndef _ASM_X86_FPROBE_H > +#define _ASM_X86_FPROBE_H > + > +#ifdef CONFIG_64BIT > +#include > +#endif > + > +#endif /* _ASM_X86_FPROBE_H */ > \ No newline at end of file Same for the above. -- Steve