From: Nir Lichtman <nir@lichtman.org>
To: Daniel Thompson <daniel.thompson@linaro.org>
Cc: kgdb-bugreport@lists.sourceforge.net,
linux-trace-kernel@vger.kernel.org, yuran.pereira@hotmail.com,
jason.wessel@windriver.com, dianders@chromium.org,
rostedt@goodmis.org, mhiramat@kernel.org,
linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH v4 0/3] Replace the use of simple_strtol/ul functions with kstrto
Date: Fri, 8 Nov 2024 11:06:39 +0000 [thread overview]
Message-ID: <20241108110639.GA118048@lichtman.org> (raw)
In-Reply-To: <173105511502.10030.8958584403113767756.b4-ty@linaro.org>
On Fri, Nov 08, 2024 at 08:38:35AM +0000, Daniel Thompson wrote:
>
> On Mon, 28 Oct 2024 19:17:00 +0000, Nir Lichtman wrote:
> > The simple_str* family of functions perform no error checking in
> > scenarios where the input value overflows the intended output variable.
> > This results in these function successfully returning even when the
> > output does not match the input string.
> >
> > Or as it was mentioned [1], "...simple_strtol(), simple_strtoll(),
> > simple_strtoul(), and simple_strtoull() functions explicitly ignore
> > overflows, which may lead to unexpected results in callers."
> > Hence, the use of those functions is discouraged.
> >
> > [...]
>
> Applied, thanks!
Thanks!
Nir
prev parent reply other threads:[~2024-11-08 11:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 19:17 [PATCH v4 0/3] Replace the use of simple_strtol/ul functions with kstrto Nir Lichtman
2024-10-28 19:19 ` [PATCH v4 1/3] kdb: Replace the use of simple_strto with safer kstrto in kdb_main Nir Lichtman
2024-10-28 21:09 ` Doug Anderson
2024-10-28 19:21 ` [PATCH v4 2/3] trace: kdb: Replace simple_strtoul with kstrtoul in kdb_ftdump Nir Lichtman
2024-10-28 19:22 ` [PATCH v4 3/3] kdb: Remove fallback interpretation of arbitrary numbers as hex Nir Lichtman
2024-11-08 8:38 ` [PATCH v4 0/3] Replace the use of simple_strtol/ul functions with kstrto Daniel Thompson
2024-11-08 11:06 ` Nir Lichtman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241108110639.GA118048@lichtman.org \
--to=nir@lichtman.org \
--cc=daniel.thompson@linaro.org \
--cc=dianders@chromium.org \
--cc=jason.wessel@windriver.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=yuran.pereira@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).