From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DAE2D1FE10A; Tue, 12 Nov 2024 14:44:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731422672; cv=none; b=D839Pi9TwgEMO3Ut4KjGxJ+VlA96UwPQsupfesqBAVp7T1f68iIqqfP2WlVNJwE8Nq4KZy8eFpiEsySWE/fKS1v2AhSoJZhVYipR/j39LpewRHorc+qiRwrlpxkANZIL+QF2726dlR1/x6POqzojAGh2FtU+ypQXy6etyPL0tFA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731422672; c=relaxed/simple; bh=spgfkYfdtxiRXj09AHTCjCq+F7GElLNu1CMfPrjHt4g=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=hd+Dyo0CAH0eKdFXcHQ+J0kYCN/cy5N4PzWX8lxvqP4dBZW2FWgEMIDeMPZbrxPmweedH4n1fKu+nZDoxBB2WceB30+BtrRwqKfPwqoQqNJhFqbKTLTguzrzJegr5iEmKAzwI8N1Z3W7oUTgNsArmaOPUZzBe33gmX9iwfrZVLY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4A02C4CECD; Tue, 12 Nov 2024 14:44:28 +0000 (UTC) Date: Tue, 12 Nov 2024 09:44:37 -0500 From: Steven Rostedt To: "Masami Hiramatsu (Google)" Cc: Alexei Starovoitov , Florent Revest , linux-trace-kernel@vger.kernel.org, LKML , Martin KaFai Lau , bpf , Alexei Starovoitov , Jiri Olsa , Alan Maguire , Mark Rutland , linux-arch@vger.kernel.org, Catalin Marinas , Will Deacon , Huacai Chen , WANG Xuerui , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Arnd Bergmann , Mathieu Desnoyers Subject: Re: [PATCH v18 12/17] fprobe: Add fprobe_header encoding feature Message-ID: <20241112094437.59848631@gandalf.local.home> In-Reply-To: <20241110001054.b0a5afb2d7bb1c09b4bd6b0b@kernel.org> References: <172991731968.443985.4558065903004844780.stgit@devnote2> <172991747946.443985.11014834036464028393.stgit@devnote2> <20241101102212.5e9d74d9@gandalf.local.home> <20241110001054.b0a5afb2d7bb1c09b4bd6b0b@kernel.org> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 10 Nov 2024 00:10:54 +0900 Masami Hiramatsu (Google) wrote: > > > +++ b/arch/x86/include/asm/fprobe.h > > > @@ -0,0 +1,9 @@ > > > +/* SPDX-License-Identifier: GPL-2.0 */ > > > +#ifndef _ASM_X86_FPROBE_H > > > +#define _ASM_X86_FPROBE_H > > > + > > > +#ifdef CONFIG_64BIT > > > +#include > > > +#endif > > > + > > > +#endif /* _ASM_X86_FPROBE_H */ > > > \ No newline at end of file > > > > Same for the above. > > OK, but x86 and riscv, we need this default template on 64bit only. > So those may keep it, right? Hmm, I wonder if we could just add: generic-$(CONFIG_X86_32) But since I don't see that used anywhere, we may need this for archs that partially have it. -- Steve