From: Steven Rostedt <rostedt@goodmis.org>
To: furkanonder <furkanonder@protonmail.com>
Cc: "linux-trace-kernel@vger.kernel.org"
<linux-trace-kernel@vger.kernel.org>,
"jkacur@redhat.com" <jkacur@redhat.com>,
"lgoncalv@redhat.com" <lgoncalv@redhat.com>
Subject: Re: [PATCH 1/3] tools/rtla: Improve code readability in timerlat_load.py
Date: Mon, 18 Nov 2024 14:34:45 -0500 [thread overview]
Message-ID: <20241118143445.4ef55735@gandalf.local.home> (raw)
In-Reply-To: <j2B-ted7pv3TaldTyqfIHrMmjq2fVyBFgnu3TskiQJsyRzy9loPTVVJoqHnrCWu5T88MDIFc612jUglH6Sxkdg9LN-I1XuITmoL70uECmus=@protonmail.com>
On Mon, 21 Oct 2024 15:09:49 +0000
furkanonder <furkanonder@protonmail.com> wrote:
> The enhancements made to timerlat_load.py are intended to improve the
> script's robustness and readability.
>
> Summary of the changes:
> - Unnecessary semicolons at the end of lines have been removed.
> - Parentheses surrounding the if statement checking args.prio have been
> eliminated.
> - String concatenation for constructing timerlat_path has been replaced
> with an f-string.
> - Spacing in a multiplication expression has been adjusted for improved
> clarity.
>
> Signed-off-by: Furkan Onder <furkanonder@protonmail.com>
BTW, should tools/tracing/rtla/sample/timerlat_load.py be executable?
chmod +x tools/tracing/rtla/sample/timerlat_load.py
?
If so, I can write a patch to update that.
-- Steve
prev parent reply other threads:[~2024-11-18 19:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 15:09 [PATCH 1/3] tools/rtla: Improve code readability in timerlat_load.py furkanonder
2024-10-22 8:28 ` Tomas Glozar
2024-11-18 19:34 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241118143445.4ef55735@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=furkanonder@protonmail.com \
--cc=jkacur@redhat.com \
--cc=lgoncalv@redhat.com \
--cc=linux-trace-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox