From: Steven Rostedt <rostedt@goodmis.org>
To: kernel test robot <lkp@intel.com>
Cc: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
Naveen N Rao <naveen@kernel.org>,
llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
"David S . Miller" <davem@davemloft.net>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Oleg Nesterov <oleg@redhat.com>,
Tzvetomir Stoyanov <tz.stoyanov@gmail.com>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH 6/6] tracing/dynevent: Adopt guard() and scoped_guard()
Date: Thu, 28 Nov 2024 11:57:56 -0500 [thread overview]
Message-ID: <20241128115756.24ab7b89@rorschach.local.home> (raw)
In-Reply-To: <202411281612.F29skJjy-lkp@intel.com>
On Thu, 28 Nov 2024 16:42:47 +0800
kernel test robot <lkp@intel.com> wrote:
> 5448d44c38557f Masami Hiramatsu 2018-11-05 97 p = strchr(event, '/');
> 5448d44c38557f Masami Hiramatsu 2018-11-05 98 if (p) {
> 5448d44c38557f Masami Hiramatsu 2018-11-05 99 system = event;
> 5448d44c38557f Masami Hiramatsu 2018-11-05 100 event = p + 1;
> 5448d44c38557f Masami Hiramatsu 2018-11-05 101 *p = '\0';
> 5448d44c38557f Masami Hiramatsu 2018-11-05 102 }
> 95c104c378dc7d Linyu Yuan 2022-06-27 103 if (!system && event[0] == '\0') {
> 8db403b9631331 Christophe JAILLET 2021-04-11 104 ret = -EINVAL;
> 8db403b9631331 Christophe JAILLET 2021-04-11 @105 goto out;
This is a legitimate bug. The "goto out" can't jump over a guard().
-- Steve
> 8db403b9631331 Christophe JAILLET 2021-04-11 106 }
> 5448d44c38557f Masami Hiramatsu 2018-11-05 107
> 79cc5c1710963f Masami Hiramatsu (Google 2024-11-26 108) guard(mutex)(&event_mutex);
> 5448d44c38557f Masami Hiramatsu 2018-11-05 109 for_each_dyn_event_safe(pos, n) {
> 5448d44c38557f Masami Hiramatsu 2018-11-05 110 if (type && type != pos->ops)
> 5448d44c38557f Masami Hiramatsu 2018-11-05 111 continue;
> 30199137c899d7 Masami Hiramatsu 2019-06-20 112 if (!pos->ops->match(system, event,
> d262271d04830e Masami Hiramatsu 2021-02-01 113 argc - 1, (const char **)argv + 1, pos))
> cb8e7a8d55e052 Masami Hiramatsu 2019-06-20 114 continue;
> cb8e7a8d55e052 Masami Hiramatsu 2019-06-20 115
> 5448d44c38557f Masami Hiramatsu 2018-11-05 116 ret = pos->ops->free(pos);
> cb8e7a8d55e052 Masami Hiramatsu 2019-06-20 117 if (ret)
> 5448d44c38557f Masami Hiramatsu 2018-11-05 118 break;
> 5448d44c38557f Masami Hiramatsu 2018-11-05 119 }
> 4313e5a613049d Steven Rostedt (Google 2022-11-23 120) tracing_reset_all_online_cpus();
> d262271d04830e Masami Hiramatsu 2021-02-01 121 out:
> d262271d04830e Masami Hiramatsu 2021-02-01 122 argv_free(argv);
> 5448d44c38557f Masami Hiramatsu 2018-11-05 123 return ret;
> 5448d44c38557f Masami Hiramatsu 2018-11-05 124 }
> 5448d44c38557f Masami Hiramatsu 2018-11-05 125
next prev parent reply other threads:[~2024-11-28 16:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-26 13:56 [PATCH 0/6] kprobes: tracing/probes: Fix and cleanup to use guard Masami Hiramatsu (Google)
2024-11-26 13:56 ` [PATCH 1/6] tracing/eprobe: Fix to release eprobe when failed to add dyn_event Masami Hiramatsu (Google)
2024-11-26 13:56 ` [PATCH 2/6] kprobes: Adopt guard() and scoped_guard() Masami Hiramatsu (Google)
2024-11-26 13:56 ` [PATCH 3/6] tracing/kprobe: " Masami Hiramatsu (Google)
2024-11-26 13:56 ` [PATCH 4/6] tracing/uprobe: " Masami Hiramatsu (Google)
2024-11-26 13:57 ` [PATCH 5/6] tracing/eprobe: " Masami Hiramatsu (Google)
2024-11-26 13:57 ` [PATCH 6/6] tracing/dynevent: " Masami Hiramatsu (Google)
2024-11-28 8:42 ` kernel test robot
2024-11-28 16:57 ` Steven Rostedt [this message]
2024-11-29 8:16 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241128115756.24ab7b89@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=anil.s.keshavamurthy@intel.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=naveen@kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oleg@redhat.com \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).