From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Nikolay Aleksandrov <razor@blackwall.org>
Cc: Andy Strohman <andrew@andrewstrohman.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Ido Schimmel <idosch@nvidia.com>, Petr Machata <petrm@nvidia.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
UNGLinuxDriver@microchip.com,
Shahed Shaikh <shshaikh@marvell.com>,
Manish Chopra <manishc@marvell.com>,
GR-Linux-NIC-Dev@marvell.com, Simon Horman <horms@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Roopa Prabhu <roopa@nvidia.com>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
bridge@lists.linux.dev
Subject: Re: [PATCH net-next] bridge: Make the FDB consider inner tag for Q-in-Q
Date: Sat, 30 Nov 2024 18:08:15 +0200 [thread overview]
Message-ID: <20241130160815.4n5hnr44v6ea3m44@skbuf> (raw)
In-Reply-To: <Z0s3pDGGE0zXq0UE@penguin>
On Sat, Nov 30, 2024 at 06:04:52PM +0200, Nikolay Aleksandrov wrote:
> Hi,
> This patch makes fdb lookups slower for everybody, ruins the nice key alignment,
> increases the key memory usage and adds more complexity for a corner case, especially
> having 2 different hosts with identical macs sounds weird. Fdb matching on both tags
> isn't a feature I've heard of, I don't know if there are switches that support it.
> Could you point to anywhere in the specs that such support is mentioned?
> Also could you please give more details about the use case? Maybe we can help you solve
> your problem without impacting everyone. Perhaps we can mix vlan-aware bridge and tc
> to solve it. As it stands I'm against adding such matching, but I'd love to hear what
> other people think.
>
> Cheers,
> Nik
Correct, I was also going to plan asking Andy what is his plan on making
switchdev digest this. The switch ASICs I'm most familiar with can learn
on inner VID or outer VID, but not both. Like you, I'm also not sure
what 802.1Q says about FDB entries with 2 associated VIDs.
next prev parent reply other threads:[~2024-11-30 16:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-30 0:07 [PATCH net-next] bridge: Make the FDB consider inner tag for Q-in-Q Andy Strohman
2024-11-30 5:47 ` kernel test robot
2024-11-30 16:04 ` Nikolay Aleksandrov
2024-11-30 16:08 ` Vladimir Oltean [this message]
2024-11-30 23:03 ` Andrew Strohman
2024-11-30 22:28 ` Andrew Strohman
2024-12-02 10:06 ` Vladimir Oltean
2024-12-04 8:37 ` Andrew Strohman
2024-12-04 8:48 ` Vladimir Oltean
2024-12-04 10:12 ` Andrew Strohman
2024-12-04 10:56 ` Vladimir Oltean
2024-12-05 1:14 ` Andrew Strohman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241130160815.4n5hnr44v6ea3m44@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@andrewstrohman.com \
--cc=anthony.l.nguyen@intel.com \
--cc=bridge@lists.linux.dev \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=manishc@marvell.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
--cc=rostedt@goodmis.org \
--cc=shshaikh@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox