linux-trace-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Linux Trace Kernel <linux-trace-kernel@vger.kernel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Mike Rapoport <rppt@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ftrace: Show timings of how long nop patching took
Date: Sun, 1 Dec 2024 15:04:06 -0500	[thread overview]
Message-ID: <20241201150406.17f10247@rorschach.local.home> (raw)
In-Reply-To: <6fb1e232-3bc3-4d5d-bff9-9f1a8c784782@csgroup.eu>

On Sun, 1 Dec 2024 20:37:42 +0100
Christophe Leroy <christophe.leroy@csgroup.eu> wrote:

> Hi Steven,
> 
> Le 17/10/2024 à 17:31, Steven Rostedt a écrit :
> > From: Steven Rostedt <rostedt@goodmis.org>
> > 
> > Since the beginning of ftrace, the code that did the patching had its
> > timings saved on how long it took to complete. But this information was
> > never exposed. It was used for debugging and exposing it was always
> > something that was on the TODO list. Now it's time to expose it. There's
> > even a file that is where it should go!
> > 
> > Also include how long patching modules took as a separate value.
> > 
> >   # cat /sys/kernel/tracing/dyn_ftrace_total_info
> >   57680 pages:231 groups: 9
> >   ftrace boot update time = 14024666 (ns)
> >   ftrace module total update time = 126070 (ns)  
> 
> What is this supposed to report / measure ?
> 
> On powerpc I get:
> 
> 25850 pages:14 groups: 3
> ftrace boot update time = 0 (ns)
> ftrace module total update time = 0 (ns)

Hmm, does powerpc support "trace_clock_local()" at early boot? I
probably can just switch from using "ftrace_now()" to using
ktime_get_real_ts64(). Hmm.

-- Steve

  reply	other threads:[~2024-12-01 20:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-17 15:31 [PATCH] ftrace: Show timings of how long nop patching took Steven Rostedt
2024-12-01 19:37 ` Christophe Leroy
2024-12-01 20:04   ` Steven Rostedt [this message]
2024-12-02  6:37     ` Mike Rapoport
2024-12-02 20:05       ` Steven Rostedt
2024-12-03  7:21         ` Christophe Leroy
2024-12-03 15:17           ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241201150406.17f10247@rorschach.local.home \
    --to=rostedt@goodmis.org \
    --cc=christophe.leroy@csgroup.eu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rppt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).