From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6CB76FC3; Wed, 4 Dec 2024 01:20:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733275208; cv=none; b=lkC8JplPKlVxs7v+qhFSmU6WPFMBBRTwo+xX+Dc5lZBnPRDNkgfFK4suK5BqTnRaVtuPeMVDzA3rlZe1+cJhV3SnZ6kKq+wbbjNjzQ39oRjL4EJt/FKpbHtWPzsWqKI7Zz0XoJKZfeZcvQaPQxIrZiqMvNeVXdaTuXbbKd2WSUs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733275208; c=relaxed/simple; bh=OFHHksg4BEg9aSBzLuTbIxjtWmZ3Pa2TRSNwyVKduTA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ULUP5PFSkjHc72aaJDwYEe1OSbGZDfec4yIdvHVi0txSKZKmjhja8gt6rJZ7JEtff4yCzOZuU/5IAir5OWJy6FiZJGjguXhuUOt7McOFSWt5iNnb2BSfLfpUYqJxjgyBZz50hRQLoyyNeP05oY2xepiDdBBIiMDlT5Zq0GJmBx8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0817C4CEDC; Wed, 4 Dec 2024 01:20:06 +0000 (UTC) Date: Tue, 3 Dec 2024 20:20:08 -0500 From: Steven Rostedt To: Shuah Khan Cc: Hari Bathini , Shuah Khan , linux-kselftest@vger.kernel.org, Masami Hiramatsu , Michael Ellerman , Madhavan Srinivasan , "Naveen N. Rao" , linuxppc-dev , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] selftests/ftrace: adjust offset for kprobe syntax error test Message-ID: <20241203202008.1f30a266@gandalf.local.home> In-Reply-To: References: <20241129202621.721159-1-hbathini@linux.ibm.com> <20241202144111.75d1bb3b@gandalf.local.home> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 3 Dec 2024 18:01:06 -0700 Shuah Khan wrote: > On 12/2/24 12:41, Steven Rostedt wrote: > > On Sat, 30 Nov 2024 01:56:21 +0530 > > Hari Bathini wrote: > > > >> In 'NOFENTRY_ARGS' test case for syntax check, any offset X of > >> `vfs_read+X` except function entry offset (0) fits the criterion, > >> even if that offset is not at instruction boundary, as the parser > >> comes before probing. But with "ENDBR64" instruction on x86, offset > >> 4 is treated as function entry. So, X can't be 4 as well. Thus, 8 > >> was used as offset for the test case. On 64-bit powerpc though, any > >> offset <= 16 can be considered function entry depending on build > >> configuration (see arch_kprobe_on_func_entry() for implementation > >> details). So, use `vfs_read+20` to accommodate that scenario too. > >> > >> Suggested-by: Masami Hiramatsu > >> Signed-off-by: Hari Bathini > > > > Acked-by: Steven Rostedt (Google) > > > > Shuah, > > > > Can you take this through your tree? > > Yes I can take it. I do have question about whether this is > a fix - sounds like it is from the change log. > > Clearly stating that it is a fix will help so it can be picked > up for stables. I would say it's a fix, as the test currently fails in certain scenarios for powerpc. You can add: Fixes: 4231f30fcc34a ("selftests/ftrace: Add BTF arguments test cases") -- Steve