From: Al Viro <viro@zeniv.linux.org.uk>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-trace-kernel@vger.kernel.org,
Michal Simek <monstr@monstr.eu>,
linux-kernel@vger.kernel.org
Subject: [heads up] microblaze ftrace breakage since 60b1f578b578 "ftrace: Get the true parent ip for function tracer"
Date: Wed, 4 Dec 2024 04:43:42 +0000 [thread overview]
Message-ID: <20241204044342.GQ3387508@ZenIV> (raw)
For one thing, microblaze does *not* have kernel_stack_pointer(),
so defaults would not work there. That leads to build breakage in
kernel/trace/trace_function.c since the commit in question. Breakage is
trivial to reproduce - just enable FUNCTION_GRAPH_TRACER and try to
build the kernel...
Moreover, unless I'm misreading their mcount.S, the registers saved
there are *NOT* in their pt_regs layout - the stored data is
r15 (return address of _mcount())
r2..r14
r16..r31
and all of that is at r1 - 120, where r1 is the kernel stack pointer at the
time of _mcount() call. So those defaults would be all wrong anyway.
The last time I touched microblaze assembler had been a dozen years
ago, so I'd rather avoid trying to patch the things up there - not with
live microblaze maintainers around, TYVM...
reply other threads:[~2024-12-04 4:43 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241204044342.GQ3387508@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=monstr@monstr.eu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).