* [heads up] microblaze ftrace breakage since 60b1f578b578 "ftrace: Get the true parent ip for function tracer"
@ 2024-12-04 4:43 Al Viro
0 siblings, 0 replies; only message in thread
From: Al Viro @ 2024-12-04 4:43 UTC (permalink / raw)
To: Steven Rostedt; +Cc: linux-trace-kernel, Michal Simek, linux-kernel
For one thing, microblaze does *not* have kernel_stack_pointer(),
so defaults would not work there. That leads to build breakage in
kernel/trace/trace_function.c since the commit in question. Breakage is
trivial to reproduce - just enable FUNCTION_GRAPH_TRACER and try to
build the kernel...
Moreover, unless I'm misreading their mcount.S, the registers saved
there are *NOT* in their pt_regs layout - the stored data is
r15 (return address of _mcount())
r2..r14
r16..r31
and all of that is at r1 - 120, where r1 is the kernel stack pointer at the
time of _mcount() call. So those defaults would be all wrong anyway.
The last time I touched microblaze assembler had been a dozen years
ago, so I'd rather avoid trying to patch the things up there - not with
live microblaze maintainers around, TYVM...
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-12-04 4:43 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-04 4:43 [heads up] microblaze ftrace breakage since 60b1f578b578 "ftrace: Get the true parent ip for function tracer" Al Viro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).