From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B4373B791; Fri, 20 Dec 2024 15:08:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734707298; cv=none; b=FFhIvivfD8x9Q9c4YU6YrBKTl5ToLCXEeHeswcLhL+xKe/IIzsBUixnqd5rsthaqIvmIhichULO75MYCVb9Z19AXakp1zx4VAuQa41g6rpBMy0VdVJoMkgwEfcjLQhOFP/8PLnAw28+US0k1x0NnqwlNlExYBN26xShoH/TvDk0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734707298; c=relaxed/simple; bh=tELedgPU/p+PB7SMxOQXyZszI7vj7VOGC/D7C6tBVYc=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=eovNAGWc8T/sRDRmQbGOCoFxLJcTwutgcIy7n5EbsAMD7h9yU2a2aAfRR8ayrLHsUQ1O7ILzGrEISkObsC1MRguHrD7uTah41clQsreKPsODNAEI70KsEUgSt4O6WSmjScnTqhrX0bJoM93zBp8jzt9OZehuNFsKjXFnd4XSiXc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7278BC4CECD; Fri, 20 Dec 2024 15:08:13 +0000 (UTC) Date: Fri, 20 Dec 2024 10:08:56 -0500 From: Steven Rostedt To: Heiko Carstens Cc: "Masami Hiramatsu (Google)" , Alexei Starovoitov , Florent Revest , linux-trace-kernel@vger.kernel.org, LKML , Martin KaFai Lau , bpf , Alexei Starovoitov , Jiri Olsa , Alan Maguire , Mark Rutland , linux-arch@vger.kernel.org, Will Deacon , Catalin Marinas , Huacai Chen , WANG Xuerui , Paul Walmsley , Palmer Dabbelt , Albert Ou , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Mathieu Desnoyers Subject: Re: [PATCH v21 03/20] fgraph: Replace fgraph_ret_regs with ftrace_regs Message-ID: <20241220100856.1a436ad3@gandalf.local.home> In-Reply-To: <20241220145156.12646-B-hca@linux.ibm.com> References: <173379652547.973433.2311391879173461183.stgit@devnote2> <173379656618.973433.13429645373226409113.stgit@devnote2> <20241219163448.7fe08f79@gandalf.local.home> <20241220145156.12646-B-hca@linux.ibm.com> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 20 Dec 2024 15:51:56 +0100 Heiko Carstens wrote: > On Thu, Dec 19, 2024 at 04:34:48PM -0500, Steven Rostedt wrote: > > On Tue, 10 Dec 2024 11:09:26 +0900 > > "Masami Hiramatsu (Google)" wrote: > > > > > From: Masami Hiramatsu (Google) > > > > > > Use ftrace_regs instead of fgraph_ret_regs for tracing return value > > > on function_graph tracer because of simplifying the callback interface. > > > > > > The CONFIG_HAVE_FUNCTION_GRAPH_RETVAL is also replaced by > > > CONFIG_HAVE_FUNCTION_GRAPH_FREGS. > > > > > > Signed-off-by: Masami Hiramatsu (Google) > > > Acked-by: Heiko Carstens > > > > Did Heiko ack this? I don't see it in my inbox. > > Yes, I did: > https://lore.kernel.org/lkml/20240916121656.20933-B-hca@linux.ibm.com/ Oh OK. I didn't go back that far as it appeared you questioned this patch in v16: https://lore.kernel.org/all/20241016083323.16801-A-hca@linux.ibm.com/ > > > Heiko, > > > > Does the above look OK to you? > > Looks still good to me. Thanks, I'll likely pull in the series after rc4 and get it ready for linux-next. -- Steve