From: Steven Rostedt <rostedt@goodmis.org>
To: Lukas Wunner <lukas@wunner.de>
Cc: Shuai Xue <xueshuai@linux.alibaba.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-edac@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
helgaas@kernel.org, bhelgaas@google.com, tony.luck@intel.com,
bp@alien8.de, mhiramat@kernel.org,
mathieu.desnoyers@efficios.com, oleg@redhat.com,
naveen@kernel.org, davem@davemloft.net,
anil.s.keshavamurthy@intel.com, mark.rutland@arm.com,
peterz@infradead.org, tianruidong@linux.alibaba.com
Subject: Re: [PATCH v6] PCI: hotplug: Add a generic RAS tracepoint for hotplug event
Date: Wed, 15 Jan 2025 10:05:47 -0500 [thread overview]
Message-ID: <20250115100547.63dec2d7@gandalf.local.home> (raw)
In-Reply-To: <Z4eA866i9eup6os3@wunner.de>
On Wed, 15 Jan 2025 10:33:39 +0100
Lukas Wunner <lukas@wunner.de> wrote:
> > >
> > > TP_STRUCT__entry(
> > > __string( port_name, pci_name(ctrl->pcie->port) )
> > > __string( slot, slot_name(ctrl) )
> > > __field( int, event )
> > >
> > > and everything else could be the same.
> >
> > Maybe it's not a good idea.
> >
> > I think pci_hp_event is a generic event for pciehp, shpchp, octep_hp, etc.
> > But each hotplug driver has different `struct controller` and slot_name().
> [...]
> > So, IMHO, pass port_name and slot_name from each driver is more simple.
> >
> > + @Lukas for hotplug part.
>
> You're right Shuai, there's several hotplug drivers in drivers/pci/hotplug/
> and pciehp is just one of them. It's quite possible that other drivers
> besides pciehp will want to add trace points as well. For consistency,
> the trace event definitions need to work for all drivers.
OK, if this is a generic trace event then it does make sense sending in the
names instead of the structure.
-- Steve
next prev parent reply other threads:[~2025-01-15 15:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-15 1:37 [PATCH v6] PCI: hotplug: Add a generic RAS tracepoint for hotplug event Shuai Xue
2025-01-15 2:41 ` Steven Rostedt
2025-01-15 3:59 ` Shuai Xue
2025-01-15 9:33 ` Lukas Wunner
2025-01-15 15:05 ` Steven Rostedt [this message]
2025-01-18 5:13 ` kernel test robot
2025-01-18 17:52 ` kernel test robot
2025-02-24 3:38 ` Shuai Xue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250115100547.63dec2d7@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=anil.s.keshavamurthy@intel.com \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=davem@davemloft.net \
--cc=helgaas@kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=naveen@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=tianruidong@linux.alibaba.com \
--cc=tony.luck@intel.com \
--cc=xueshuai@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).