From: Steven Rostedt <rostedt@goodmis.org>
To: Daniel Wagner <dwagner@suse.de>
Cc: linux-trace-kernel@vger.kernel.org,
Masami Hiramatsu <mhiramat@kernel.org>
Subject: Re: kprobe not always triggering
Date: Wed, 15 Jan 2025 11:37:33 -0500 [thread overview]
Message-ID: <20250115113733.650db5c0@gandalf.local.home> (raw)
In-Reply-To: <e5d64ac8-5a30-4196-a5e5-b3d2743356b1@flourine.local>
On Wed, 15 Jan 2025 17:29:34 +0100
Daniel Wagner <dwagner@suse.de> wrote:
> > There's been cases of a compiler inlining some functions for the code
> > called in the same file. If that happened, then those will likely be
> > dropped. That can be tested by adding:
> >
> > bool noinline nvme_change_ctrl_state(struct nvme_ctrl *ctrl,
> > enum nvme_ctrl_state new_state)
> >
> > You would think it shouldn't inline it, but there's nothing in the spec
> > that says it can't do so.
>
> This did the trick, now I see the missing state transitions.
Grumble. I expect this issue to come up more often. We need a way to detect
this. Come to think of it, I believe this is more of a clang "feature". As
I do recall some of the other reports were from the clang compiler as well.
-- Steve
next prev parent reply other threads:[~2025-01-15 16:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-15 8:26 kprobe not always triggering Daniel Wagner
2025-01-15 15:17 ` Steven Rostedt
2025-01-15 16:29 ` Daniel Wagner
2025-01-15 16:37 ` Steven Rostedt [this message]
2025-01-15 16:50 ` Daniel Wagner
2025-01-15 23:48 ` Masami Hiramatsu
2025-01-16 12:04 ` Daniel Wagner
2025-01-17 8:52 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250115113733.650db5c0@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=dwagner@suse.de \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox