From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1A5435968 for ; Thu, 16 Jan 2025 14:40:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737038446; cv=none; b=D3a2B08tollVkE3HDTix9Dfy5kwAh84J7i7V6MMZkdbLcCvEdJMz7YtHSWLc0WEwhqgBsqmM93gONuXBid7rU+6bgHDRBggxn3gky8PrVW2Fyrq+D32B4uqlVP0US361kXtEzCXCA1LIJ70iLyZrtIpWiY9fADhGbeOOhbHKhFw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737038446; c=relaxed/simple; bh=njqXd/uQ+QT9aanmRxZO+r+o7uxJnuiyyh1zBELECRM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=vDvzIVna76FY6tjtUPl8soPNPHzNpG/V7UQNppsh5X6jaSlK0PpNZ7GowUkmKyxZoVpkgYBLzA/0vAIYHMz3WP+yPVOYj/PxEAffwMmH1UvUeslR57Ct/Nd/tz1hbez5pAqHGiQAp10uuQuwsy2fMe6hNjI1aJIQn1P6J11xj8k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=MQykYSP7; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MQykYSP7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737038443; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Cb/9KjaC//7ekSA5D4ZTqkLvXMQfEqyfvg4jgXEsaAk=; b=MQykYSP7GqvY60OTyJmsp8pv0QsOam3/InxUPPb+eAzbkoEuTfgGNYilierPdKE9qaxi4x r55I8FDrvErz8RrY2F1ojnlwfmmhu6xpF5vwl5QJ8Wse6UYa9GV64EqpjFvkHcfoO0yhRj d0t13cayLhKUdbTalbG5krUPQ6lnT/0= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-341-G7yyzW9yO2WCYMiQJsup1g-1; Thu, 16 Jan 2025 09:40:37 -0500 X-MC-Unique: G7yyzW9yO2WCYMiQJsup1g-1 X-Mimecast-MFC-AGG-ID: G7yyzW9yO2WCYMiQJsup1g Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3DCF419560AA; Thu, 16 Jan 2025 14:40:33 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.224.118]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 55A0619560BF; Thu, 16 Jan 2025 14:40:23 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Thu, 16 Jan 2025 15:40:08 +0100 (CET) Date: Thu, 16 Jan 2025 15:39:57 +0100 From: Oleg Nesterov To: Eyal Birger Cc: Alexei Starovoitov , Jiri Olsa , Aleksa Sarai , Masami Hiramatsu , linux-kernel , linux-trace-kernel , BPF-dev-list , Song Liu , Yonghong Song , John Fastabend , Peter Zijlstra , Thomas Gleixner , Borislav Petkov , X86 ML , Linux API , Andrii Nakryiko , Daniel Borkmann , Alexei Starovoitov , Andrii Nakryiko , "rostedt@goodmis.org" , rafi@rbk.io, Shmulik Ladkani Subject: Re: Crash when attaching uretprobes to processes running in Docker Message-ID: <20250116143956.GD21801@redhat.com> References: <20250114143313.GA29305@redhat.com> <20250114172519.GB29305@redhat.com> <20250115150607.GA11980@redhat.com> <20250115184011.GA21801@redhat.com> <20250115190304.GB21801@redhat.com> Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 On 01/15, Eyal Birger wrote: > > On Wed, Jan 15, 2025 at 11:03 AM Oleg Nesterov wrote: > > > > On 01/15, Eyal Birger wrote: > > > > > > --- a/kernel/seccomp.c > > > +++ b/kernel/seccomp.c > > > @@ -1359,6 +1359,9 @@ int __secure_computing(const struct seccomp_data *sd) > > > this_syscall = sd ? sd->nr : > > > syscall_get_nr(current, current_pt_regs()); > > > > > > + if (this_syscall == __NR_uretprobe) > > > + return 0; > > > + > > > > Yes, this is what I meant. But we need the new arch-dependent helper. > > Do you mean because __NR_uretprobe is not defined for other architectures? Yes, and see below, > Is there an existing helper? I wasn't able to find one... No, > If not, would it just make sense to just wrap this check in > #ifdef __NR_uretprobe ? Given that we need a simple fix for -stable, I won't argue. Up to seccomp maintainers. But please note that this_syscall == __NR_uretprobe can be false positive if is_compat_task(). __NR_uretprobe == __NR_ia32_rt_tgsigqueueinfo, so I guess we need #ifdef CONFIG_X86_64 if (this_syscall == __NR_uretprobe && !in_ia32_syscall()) return 0; #endif I don't think we need to worry about the X86_X32 tasks... Oleg.