From: Steven Rostedt <rostedt@goodmis.org>
To: Tomas Glozar <tglozar@redhat.com>
Cc: linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org,
John Kacur <jkacur@redhat.com>,
Luis Goncalves <lgoncalv@redhat.com>,
Gabriele Monaco <gmonaco@redhat.com>
Subject: Re: [PATCH 3/5] rtla/timerlat_top: Stop timerlat tracer on signal
Date: Fri, 17 Jan 2025 05:50:01 -0500 [thread overview]
Message-ID: <20250117055001.5c8de382@gandalf.local.home> (raw)
In-Reply-To: <CAP4=nvQUugz723Qav2xBD97ud6sM=ajEeNqyAVyqL1Qf09ZX=Q@mail.gmail.com>
On Fri, 17 Jan 2025 08:13:26 +0100
Tomas Glozar <tglozar@redhat.com> wrote:
> > A change log should never reference another patch. This is meaningless when
> > seen in a git log. All change logs must be complete stand alone.
>
> If you look up "previous patch" in the Linux commit log, you will find
> a considerable amount of patches which do this:
>
> $ git log master | grep 'previous patch' | wc -l
> 3006
As Linus has scolded me before with "Just because someone else did it wrong
doesn't give you the excuse to do it wrong too" ;-)
-- Steve
next prev parent reply other threads:[~2025-01-17 10:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 14:49 [PATCH 0/5] rtla/timerlat: Stop on signal properly when overloaded Tomas Glozar
2025-01-16 14:49 ` [PATCH 1/5] rtla: Add trace_instance_stop Tomas Glozar
2025-01-16 14:49 ` [PATCH 2/5] rtla/timerlat_hist: Stop timerlat tracer on signal Tomas Glozar
2025-01-16 14:49 ` [PATCH 3/5] rtla/timerlat_top: " Tomas Glozar
2025-01-17 0:56 ` Steven Rostedt
2025-01-17 7:13 ` Tomas Glozar
2025-01-17 10:50 ` Steven Rostedt [this message]
2025-01-16 14:49 ` [PATCH 4/5] rtla/timerlat_hist: Abort event processing on second signal Tomas Glozar
2025-01-16 14:49 ` [PATCH 5/5] rtla/timerlat_top: " Tomas Glozar
2025-01-17 0:57 ` Steven Rostedt
2025-01-17 6:58 ` Gabriele Monaco
2025-01-17 0:46 ` [PATCH 0/5] rtla/timerlat: Stop on signal properly when overloaded Steven Rostedt
2025-01-17 12:04 ` Tomas Glozar
2025-01-17 15:29 ` Steven Rostedt
2025-01-17 15:55 ` Tomas Glozar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250117055001.5c8de382@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=gmonaco@redhat.com \
--cc=jkacur@redhat.com \
--cc=lgoncalv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=tglozar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox