From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 563F8186E58; Mon, 20 Jan 2025 18:09:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737396540; cv=none; b=HTZ1iQXJ70OCMtcW6/0iN9BaVWzs9UP3NjaxoNvdYBiqV6MIkmjvuHJUByeacbh+wMGAlOUnZjfyXTciWGZfg2GTafxIapKAES82dDt+keTwfXS0lCnEamgBiE+2qhwmWwy56kNipYqQ0N1n1AEfNQW+6a0lbmfSd+K6vV/Wwck= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737396540; c=relaxed/simple; bh=J8ixhOMyCVCQ5l8UQInx+eVnEbD3DkvBNtC4H4UZYFE=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QS1D1LukICb55ayEWpa38KPAkWFDYVPyGEVkhDyMgxfohmdpaU3Unu7CWbv4iit1tZXm3iYLxyF7zk9+/Iawh5mPgRrCt6H1jVLRTjvvfz7nqoERGo1xzSYIlZ4k+Xm/FYdU+MeKYS99ndqC5nsKV1Ncr5fTLr3I2JLiUAJ4lOM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 71246C4CEDD; Mon, 20 Jan 2025 18:08:59 +0000 (UTC) Date: Mon, 20 Jan 2025 13:09:00 -0500 From: Steven Rostedt To: LKML , Linux Trace Kernel Cc: Masami Hiramatsu , Mathieu Desnoyers , Linus Torvalds , kernel test robot Subject: Re: [PATCH] tracing: Fix #if CONFIG_MODULES to #ifdef CONFIG_MODULES Message-ID: <20250120130900.09a5ffba@gandalf.local.home> In-Reply-To: <20250120125745.4ac90ca6@gandalf.local.home> References: <20250120125745.4ac90ca6@gandalf.local.home> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 20 Jan 2025 12:57:45 -0500 Steven Rostedt wrote: > From: Steven Rostedt > > A typo was introduced when adding the ":mod:" command that did > a "#if CONFIG_MODULES" instead of a "#ifdef CONFIG_MODULES". > Fix it. > > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202501110319.xY9ltUxL-lkp@intel.com/ Cut and paste error. Wrong closes: Should have been: Closes: https://lore.kernel.org/oe-kbuild-all/202501190121.E2CIJuUj-lkp@intel.com/ -- Steve > Fixes: b355247df104e ("tracing: Cache ":mod:" events for modules not loaded yet") > Signed-off-by: Steven Rostedt (Google) > --- > kernel/trace/trace_events.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c > index f762e554fad4..bb1406719c3f 100644 > --- a/kernel/trace/trace_events.c > +++ b/kernel/trace/trace_events.c > @@ -857,7 +857,7 @@ static int ftrace_event_enable_disable(struct trace_event_file *file, > return __ftrace_event_enable_disable(file, enable, 0); > } > > -#if CONFIG_MODULES > +#ifdef CONFIG_MODULES > struct event_mod_load { > struct list_head list; > char *module;