From: Steven Rostedt <rostedt@goodmis.org>
To: Wander Lairson Costa <wander@redhat.com>
Cc: "Masami Hiramatsu" <mhiramat@kernel.org>,
"Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>,
"Darrick J. Wong" <djwong@kernel.org>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Takashi Iwai" <tiwai@suse.de>,
linux-kernel@vger.kernel.org (open list:TRACING),
linux-trace-kernel@vger.kernel.org (open list:TRACING)
Subject: Re: [PATCH] irq/tracing: Add IRQ name to irq_handler_exit tracepoint
Date: Thu, 30 Jan 2025 14:07:46 -0500 [thread overview]
Message-ID: <20250130140746.29cfa7d1@gandalf.local.home> (raw)
In-Reply-To: <20250130181439.58130-1-wander@redhat.com>
On Thu, 30 Jan 2025 15:14:38 -0300
Wander Lairson Costa <wander@redhat.com> wrote:
> The irq_handler_entry tracepoint includes a "name" field, which allows
> for easy identification and filtering of specific IRQs. However, the
> irq_handler_exit tracepoint lacks this field, making it difficult to
> pair corresponding entry and exit events for analysis.
>
> Add the "name" field to irq_handler_exit to enable consistent tracking
> and correlation of IRQ entry and exit events.
I'm not sure what you mean by this.
# trace-cmd record -e irq_handl* sleep 5
# trace-cmd report
<idle>-0 [000] d.h1. 4690.628641: irq_handler_entry: irq=55 name=virtio5-output.0
<idle>-0 [000] d.h1. 4690.628650: irq_handler_exit: irq=55 ret=handled
<idle>-0 [007] d.H1. 4690.628895: irq_handler_entry: irq=54 name=virtio5-input.0
<idle>-0 [007] d.H1. 4690.628900: irq_handler_exit: irq=54 ret=handled
<idle>-0 [000] d.h1. 4690.802977: irq_handler_entry: irq=41 name=virtio2-req.0
<idle>-0 [000] dNh1. 4690.803046: irq_handler_exit: irq=41 ret=handled
<idle>-0 [000] d.h1. 4690.813958: irq_handler_entry: irq=41 name=virtio2-req.0
<idle>-0 [000] dNh1. 4690.814008: irq_handler_exit: irq=41 ret=handled
<idle>-0 [000] d.H1. 4690.814257: irq_handler_entry: irq=41 name=virtio2-req.0
<idle>-0 [000] dNH1. 4690.814301: irq_handler_exit: irq=41 ret=handled
<idle>-0 [000] d.H1. 4690.815374: irq_handler_entry: irq=41 name=virtio2-req.0
# cat /proc/interrupts |grep -e 55 -e 54 -e 41
41: 462 0 0 0 0 0 0 0 PCI-MSIX-0000:04:00.0 1-edge virtio2-req.0
54: 0 0 0 0 0 0 0 4539 PCI-MSIX-0000:07:00.0 1-edge virtio5-input.0
55: 4544 0 0 0 0 0 0 0 PCI-MSIX-0000:07:00.0 2-edge virtio5-output.0
RES: 1293 1411 1357 1307 1343 1345 1330 1315 Rescheduling interrupts
We have the names right there. Heck, I could probably write a plugin for
trace-cmd to record the interrupt names in the trace.dat file and print
them out with the events. Any analysis tool could also record that.
That's better than wasting ring buffer space for every event.
-- Steve
next prev parent reply other threads:[~2025-01-30 19:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-30 18:14 [PATCH] irq/tracing: Add IRQ name to irq_handler_exit tracepoint Wander Lairson Costa
2025-01-30 19:07 ` Steven Rostedt [this message]
2025-01-31 12:15 ` Wander Lairson Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250130140746.29cfa7d1@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=djwong@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rafael@kernel.org \
--cc=thomas.hellstrom@linux.intel.com \
--cc=tiwai@suse.de \
--cc=wander@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox