From: Keita Morisaki <keyz@google.com>
To: khilman@kernel.org
Cc: aarontian@google.com, daniel.lezcano@linaro.org, keyz@google.com,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, lpieralisi@kernel.org,
mathieu.desnoyers@efficios.com, mhiramat@kernel.org,
rafael@kernel.org, rostedt@goodmis.org, sudeep.holla@arm.com,
yimingtseng@google.com
Subject: Re: [PATCH v3] cpuidle: psci: Add trace for PSCI domain idle
Date: Sun, 2 Feb 2025 18:42:11 +0800 [thread overview]
Message-ID: <20250202104211.2764016-1-keyz@google.com> (raw)
In-Reply-To: <7hy0ysi4pf.fsf@baylibre.com>
> Tested-by: Kevin Hilman <khilman@baylibre.com>
>
> I've been using some local trace_printk() to do exactly this, so I fully
> support having some official tracepoints here.
>
> For my local hacks, I was trackin the state index as well as the state
> value since for quick debug, I find the index to more human readable
> than the state value, which I have to compare with the
> arm,psci-suspend-pararm from the DT.
>
> Anyways, thanks for submitting this!
>
> Kevin
Thank you so much for the endorsement.
Showing the index sounds like a good idea, although it should be done in a
different layer (probably in the GenPD governor or cpuidle-psci driver?) because
idx here should be the different index from the one we're looking for.
I will keep my patch as it is just for now. Thank you for the idea!
next prev parent reply other threads:[~2025-02-02 10:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-17 4:01 [PATCH] cpuidle: psci: Add trace for PSCI domain idle Keita Morisaki
2025-01-17 15:51 ` Steven Rostedt
2025-01-18 7:24 ` Keita Morisaki
2025-01-20 1:36 ` [PATCH v2] " Keita Morisaki
2025-01-24 20:28 ` Steven Rostedt
2025-01-25 1:27 ` Keita Morisaki
2025-01-25 1:31 ` [PATCH v3] " Keita Morisaki
2025-01-30 17:36 ` Kevin Hilman
2025-02-02 10:42 ` Keita Morisaki [this message]
2025-02-02 10:46 ` [PATCH v4] " Keita Morisaki
2025-02-03 5:32 ` Dhruva Gole
2025-01-27 12:16 ` [PATCH v2] " Christian Loehle
2025-01-28 4:24 ` Keita Morisaki
2025-01-28 11:06 ` Christian Loehle
2025-01-29 8:51 ` Keita Morisaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250202104211.2764016-1-keyz@google.com \
--to=keyz@google.com \
--cc=aarontian@google.com \
--cc=daniel.lezcano@linaro.org \
--cc=khilman@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rafael@kernel.org \
--cc=rostedt@goodmis.org \
--cc=sudeep.holla@arm.com \
--cc=yimingtseng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).