Re: [PATCH v4 12/39] unwind_user: Add frame pointer support

Steven Rostedt
2025-04-24T13:39:11Z

On Fri, 24 Jan 2025 10:16:10 -0800
Josh Poimboeuf <jpoimboe@kernel.org> wrote:

> > Do you plan to reuse this logic for stack unwinding done by perf
> > subsystem in perf_callchain_user()? See is_uprobe_at_func_entry()
> > parts and also fixup_uretprobe_trampoline_entries() for some of the
> > quirks that have to be taken into account when doing frame
> > pointer-based unwinding. It would be great not to lose those in this
> > new reimplementation.
> >
> > Not sure what's the best way to avoid duplicating the logic, but I
> > thought I'd bring that up.
>
> Indeed! That was on the todo list and somehow evaporated.

I'm getting ready to post an update of these patches, but I want to mention
that this has not been addressed, and I'm replying here to make sure it
stays on the radar.

-- Steve