Re: [PATCH v4 09/39] x86/vdso: Enable sframe generation in VDSO

Josh Poimboeuf
2025-01-24T16:56:14Z

On Fri, Jan 24, 2025 at 05:30:36PM +0100, Jens Remus wrote:
> On 22.01.2025 03:31, Josh Poimboeuf wrote:
> > Enable sframe generation in the VDSO library so kernel and user space
> > can unwind through it.
> >
> > Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
>
> > diff --git a/arch/x86/entry/vdso/Makefile b/arch/x86/entry/vdso/Makefile
>
> > @@ -47,13 +47,17 @@ quiet_cmd_vdso2c = VDSO2C $@
> > $(obj)/vdso-image-%.c: $(obj)/vdso%.so.dbg $(obj)/vdso%.so $(obj)/vdso2c FORCE
> > $(call if_changed,vdso2c)
> > +#ifdef CONFIG_AS_SFRAME
> > +SFRAME_CFLAGS := -Wa$(comma)-gsframe
> > +#endif
> > +
>
> You probably erroneously mixed up C preprocessor and Makefile syntax? :-)
>
> ifeq ($(CONFIG_AS_SFRAME),y)
> SFRAME_CFLAGS := -Wa,--gsframe
> endif
>
> $(comma) does not appear to be required in this context.

Yeah, before it was in a Makefile macro which needed the $(comma) to
distinguish it from the macro arguments.

--
Josh