Re: [PATCH v4 09/39] x86/vdso: Enable sframe generation in VDSO

Steven Rostedt
2025-04-22T17:42:14Z

On Fri, 24 Jan 2025 08:43:32 -0800
Josh Poimboeuf <jpoimboe@kernel.org> wrote:

> On Fri, Jan 24, 2025 at 05:00:27PM +0100, Jens Remus wrote:
> > On 22.01.2025 03:31, Josh Poimboeuf wrote:
> > > diff --git a/arch/x86/include/asm/dwarf2.h b/arch/x86/include/asm/dwarf2.h
> > > index b195b3c8677e..1c354f648505 100644
> > > --- a/arch/x86/include/asm/dwarf2.h
> > > +++ b/arch/x86/include/asm/dwarf2.h
> > > @@ -12,8 +12,11 @@
> > > * For the vDSO, emit both runtime unwind information and debug
> > > * symbols for the .dbg file.
> > > */
> > > -
> >
> > Nit: Deleted blank line you introduced in "[PATCH v4 05/39] x86/asm:
> > Avoid emitting DWARF CFI for non-VDSO".
>
> Indeed.

Note, I'm getting ready to send out an update of Josh's patches.

This particular nit isn't really an issue, as #ifdef's do sometimes replace
blank lines.

Just mentioning this so you don't think I'm ignoring it, when I post patches.

-- Steve