Re: [PATCH v4 19/39] unwind_user/sframe: Add support for reading .sframe contents

Josh Poimboeuf
2025-01-24T17:07:41Z

On Fri, Jan 24, 2025 at 05:36:38PM +0100, Jens Remus wrote:
> On 22.01.2025 03:31, Josh Poimboeuf wrote:
>
> > diff --git a/include/linux/sframe.h b/include/linux/sframe.h
>
> > @@ -3,11 +3,14 @@
> > #define _LINUX_SFRAME_H
> > #include <linux/mm_types.h>
> > +#include <linux/srcu.h>
> > #include <linux/unwind_user_types.h>
> > #ifdef CONFIG_HAVE_UNWIND_USER_SFRAME
> > struct sframe_section {
> > + struct rcu_head rcu;
> > +
>
> Nit: You are adding a blank line, that you later remove with
> "[PATCH v4 25/39] unwind_user/sframe: Show file name in debug output".

I suppose that was intentional. The original blank line created visual
separation between the rcu head and the sframe values. The later patch
instead sort of uses the ifdef to keep some separation? But yeah, I'll
keep the blank lines for consistency. <shrug>

struct sframe_section {
struct rcu_head rcu;

#ifdef CONFIG_DYNAMIC_DEBUG
const char *filename;
#endif

unsigned long sframe_start;
unsigned long sframe_start;
unsigned long sframe_end;
unsigned long text_start;
unsigned long text_end;

unsigned long fdes_start;
unsigned long fres_start;
unsigned long fres_end;
unsigned int num_fdes;

signed char ra_off;
signed char fp_off;
};

--
Josh