Re: [PATCH v4 11/39] unwind_user: Add user space unwinding API

Josh Poimboeuf
2025-01-24T18:08:39Z

On Fri, Jan 24, 2025 at 09:59:28AM -0800, Andrii Nakryiko wrote:
> On Tue, Jan 21, 2025 at 6:32 PM Josh Poimboeuf <jpoimboe@kernel.org> wrote:
> > +int unwind_user_next(struct unwind_user_state *state)
> > +{
> > + struct unwind_user_frame _frame;
> > + struct unwind_user_frame *frame = &_frame;
> > + unsigned long cfa = 0, fp, ra = 0;
>
> wouldn't all the above generate compilation warnings about unused
> variables, potentially breaking bisection?

It doesn't break bisection because no arches support UNWIND_USER yet so
this can't yet be compiled.

But yeah, it's shoddy and I fixed it after Jens' comment about the
unnecessary zero-initialized variables.

>
> > +
> > + /* no implementation yet */
> > + -EINVAL;
>
> return missing?

heh :-)

--
Josh