From: Nico Pache <npache@redhat.com>
To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
linux-mm@kvack.org
Cc: ryan.roberts@arm.com, anshuman.khandual@arm.com,
catalin.marinas@arm.com, cl@gentwo.org, vbabka@suse.cz,
mhocko@suse.com, apopple@nvidia.com, dave.hansen@linux.intel.com,
will@kernel.org, baohua@kernel.org, jack@suse.cz,
srivatsa@csail.mit.edu, haowenchao22@gmail.com, hughd@google.com,
aneesh.kumar@kernel.org, yang@os.amperecomputing.com,
peterx@redhat.com, ioworker0@gmail.com,
wangkefeng.wang@huawei.com, ziy@nvidia.com, jglisse@google.com,
surenb@google.com, vishal.moola@gmail.com, zokeefe@google.com,
zhengqi.arch@bytedance.com, jhubbard@nvidia.com,
21cnbao@gmail.com, willy@infradead.org,
kirill.shutemov@linux.intel.com, david@redhat.com,
aarcange@redhat.com, raquini@redhat.com, dev.jain@arm.com,
sunnanyong@huawei.com, usamaarif642@gmail.com, audra@redhat.com,
akpm@linux-foundation.org, rostedt@goodmis.org,
mathieu.desnoyers@efficios.com, tiwai@suse.de
Subject: [RFC v2 9/9] khugepaged: skip collapsing mTHP to smaller orders
Date: Mon, 10 Feb 2025 17:30:28 -0700 [thread overview]
Message-ID: <20250211003028.213461-10-npache@redhat.com> (raw)
In-Reply-To: <20250211003028.213461-1-npache@redhat.com>
khugepaged may try to collapse a mTHP to a smaller mTHP, resulting in
some pages being unmapped. Skip these cases until we have a way to check
if its ok to collapse to a smaller mTHP size (like in the case of a
partially mapped folio).
This patch is inspired by Dev Jain's work on khugepaged mTHP support [1].
[1] https://lore.kernel.org/lkml/20241216165105.56185-11-dev.jain@arm.com/
Signed-off-by: Nico Pache <npache@redhat.com>
---
mm/khugepaged.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/mm/khugepaged.c b/mm/khugepaged.c
index e2ba18e57064..fc30698b8e6e 100644
--- a/mm/khugepaged.c
+++ b/mm/khugepaged.c
@@ -622,6 +622,11 @@ static int __collapse_huge_page_isolate(struct vm_area_struct *vma,
folio = page_folio(page);
VM_BUG_ON_FOLIO(!folio_test_anon(folio), folio);
+ if (order != HPAGE_PMD_ORDER && folio_order(folio) >= order) {
+ result = SCAN_PTE_MAPPED_HUGEPAGE;
+ goto out;
+ }
+
/* See khugepaged_scan_pmd(). */
if (folio_likely_mapped_shared(folio)) {
++shared;
--
2.48.1
next prev parent reply other threads:[~2025-02-11 0:32 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 0:30 [RFC v2 0/9] khugepaged: mTHP support Nico Pache
2025-02-11 0:30 ` [RFC v2 1/9] introduce khugepaged_collapse_single_pmd to unify khugepaged and madvise_collapse Nico Pache
2025-02-17 17:11 ` Usama Arif
2025-02-17 19:56 ` Nico Pache
2025-02-18 16:26 ` Ryan Roberts
2025-02-18 22:24 ` Nico Pache
2025-02-11 0:30 ` [RFC v2 2/9] khugepaged: rename hpage_collapse_* to khugepaged_* Nico Pache
2025-02-18 16:29 ` Ryan Roberts
2025-02-11 0:30 ` [RFC v2 3/9] khugepaged: generalize hugepage_vma_revalidate for mTHP support Nico Pache
2025-02-11 0:30 ` [RFC v2 4/9] khugepaged: generalize alloc_charge_folio " Nico Pache
2025-02-19 15:29 ` Ryan Roberts
2025-02-11 0:30 ` [RFC v2 5/9] khugepaged: generalize __collapse_huge_page_* " Nico Pache
2025-02-19 15:39 ` Ryan Roberts
2025-02-19 16:02 ` Nico Pache
2025-02-11 0:30 ` [RFC v2 6/9] khugepaged: introduce khugepaged_scan_bitmap " Nico Pache
2025-02-17 7:27 ` Dev Jain
2025-02-17 19:12 ` Usama Arif
2025-02-19 16:28 ` Ryan Roberts
2025-02-20 18:48 ` Nico Pache
2025-02-11 0:30 ` [RFC v2 7/9] khugepaged: add " Nico Pache
2025-02-12 17:04 ` Usama Arif
2025-02-12 18:16 ` Nico Pache
2025-02-17 20:55 ` Usama Arif
2025-02-17 21:22 ` Nico Pache
2025-02-18 4:22 ` Dev Jain
2025-03-03 19:18 ` Nico Pache
2025-03-04 5:10 ` Dev Jain
2025-02-19 16:52 ` Ryan Roberts
2025-03-03 19:13 ` Nico Pache
2025-03-05 9:11 ` Dev Jain
2025-03-05 9:07 ` Dev Jain
2025-03-07 6:38 ` Dev Jain
2025-03-07 20:14 ` Nico Pache
2025-03-10 4:17 ` Dev Jain
2025-02-11 0:30 ` [RFC v2 8/9] khugepaged: improve tracepoints for mTHP orders Nico Pache
2025-02-11 0:30 ` Nico Pache [this message]
2025-02-19 16:57 ` [RFC v2 9/9] khugepaged: skip collapsing mTHP to smaller orders Ryan Roberts
2025-02-11 12:49 ` [RFC v2 0/9] khugepaged: mTHP support Dev Jain
2025-02-12 16:49 ` Nico Pache
2025-02-13 8:26 ` Dev Jain
2025-02-13 11:21 ` Dev Jain
2025-02-13 19:39 ` Nico Pache
2025-02-14 2:01 ` Dev Jain
2025-02-15 0:52 ` Nico Pache
2025-02-15 6:38 ` Dev Jain
2025-02-17 8:05 ` Dev Jain
2025-02-17 19:19 ` Nico Pache
2025-02-17 6:39 ` Dev Jain
2025-02-17 19:15 ` Nico Pache
2025-02-18 16:07 ` Ryan Roberts
2025-02-18 22:30 ` Nico Pache
2025-02-19 9:01 ` Dev Jain
2025-02-20 19:12 ` Nico Pache
2025-02-21 4:57 ` Dev Jain
2025-02-19 17:00 ` Ryan Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250211003028.213461-10-npache@redhat.com \
--to=npache@redhat.com \
--cc=21cnbao@gmail.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@kernel.org \
--cc=anshuman.khandual@arm.com \
--cc=apopple@nvidia.com \
--cc=audra@redhat.com \
--cc=baohua@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=cl@gentwo.org \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=dev.jain@arm.com \
--cc=haowenchao22@gmail.com \
--cc=hughd@google.com \
--cc=ioworker0@gmail.com \
--cc=jack@suse.cz \
--cc=jglisse@google.com \
--cc=jhubbard@nvidia.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhocko@suse.com \
--cc=peterx@redhat.com \
--cc=raquini@redhat.com \
--cc=rostedt@goodmis.org \
--cc=ryan.roberts@arm.com \
--cc=srivatsa@csail.mit.edu \
--cc=sunnanyong@huawei.com \
--cc=surenb@google.com \
--cc=tiwai@suse.de \
--cc=usamaarif642@gmail.com \
--cc=vbabka@suse.cz \
--cc=vishal.moola@gmail.com \
--cc=wangkefeng.wang@huawei.com \
--cc=will@kernel.org \
--cc=willy@infradead.org \
--cc=yang@os.amperecomputing.com \
--cc=zhengqi.arch@bytedance.com \
--cc=ziy@nvidia.com \
--cc=zokeefe@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).