From: Breno Leitao <leitao@debian.org>
To: Eric Dumazet <edumazet@google.com>,
Neal Cardwell <ncardwell@google.com>,
Kuniyuki Iwashima <kuniyu@amazon.com>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
"David S. Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, kernel-team@meta.com,
yonghong.song@linux.dev, Breno Leitao <leitao@debian.org>
Subject: [PATCH net-next] trace: tcp: Add tracepoint for tcp_sendmsg()
Date: Mon, 24 Feb 2025 10:24:00 -0800 [thread overview]
Message-ID: <20250224-tcpsendmsg-v1-1-bac043c59cc8@debian.org> (raw)
Add a lightweight tracepoint to monitor TCP sendmsg operations, enabling
the tracing of TCP messages being sent.
Meta has been using BPF programs to monitor this function for years,
indicating significant interest in observing this important
functionality. Adding a proper tracepoint provides a stable API for all
users who need visibility into TCP message transmission.
The implementation uses DECLARE_TRACE instead of TRACE_EVENT to avoid
creating unnecessary trace event infrastructure and tracefs exports,
keeping the implementation minimal while stabilizing the API.
Given that this patch creates a rawtracepoint, you could hook into it
using regular tooling, like bpftrace, using regular rawtracepoint
infrastructure, such as:
rawtracepoint:tcp_sendmsg_tp {
....
}
Signed-off-by: Breno Leitao <leitao@debian.org>
---
include/trace/events/tcp.h | 5 +++++
net/ipv4/tcp.c | 2 ++
2 files changed, 7 insertions(+)
diff --git a/include/trace/events/tcp.h b/include/trace/events/tcp.h
index 1a40c41ff8c30..7c0171d2dacdc 100644
--- a/include/trace/events/tcp.h
+++ b/include/trace/events/tcp.h
@@ -259,6 +259,11 @@ TRACE_EVENT(tcp_retransmit_synack,
__entry->saddr_v6, __entry->daddr_v6)
);
+DECLARE_TRACE(tcp_sendmsg_tp,
+ TP_PROTO(const struct sock *sk, const struct msghdr *msg, size_t size),
+ TP_ARGS(sk, msg, size)
+);
+
DECLARE_TRACE(tcp_cwnd_reduction_tp,
TP_PROTO(const struct sock *sk, int newly_acked_sacked,
int newly_lost, int flag),
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
index 08d73f17e8162..5ef86fbd8aa85 100644
--- a/net/ipv4/tcp.c
+++ b/net/ipv4/tcp.c
@@ -1362,6 +1362,8 @@ int tcp_sendmsg(struct sock *sk, struct msghdr *msg, size_t size)
{
int ret;
+ trace_tcp_sendmsg_tp(sk, msg, size);
+
lock_sock(sk);
ret = tcp_sendmsg_locked(sk, msg, size);
release_sock(sk);
---
base-commit: e13b6da7045f997e1a5a5efd61d40e63c4fc20e8
change-id: 20250224-tcpsendmsg-4f0a236751d7
Best regards,
--
Breno Leitao <leitao@debian.org>
next reply other threads:[~2025-02-24 18:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-24 18:24 Breno Leitao [this message]
2025-02-24 19:03 ` [PATCH net-next] trace: tcp: Add tracepoint for tcp_sendmsg() Eric Dumazet
2025-02-24 19:12 ` Yonghong Song
2025-02-24 19:23 ` Eric Dumazet
2025-02-25 10:58 ` Breno Leitao
2025-02-26 23:46 ` Masami Hiramatsu
2025-02-24 19:16 ` David Ahern
2025-02-26 16:10 ` Breno Leitao
2025-02-26 17:12 ` David Ahern
2025-02-26 18:18 ` Breno Leitao
2025-02-26 18:27 ` Eric Dumazet
2025-02-26 18:31 ` David Ahern
2025-02-27 16:26 ` Breno Leitao
2025-04-02 12:57 ` Breno Leitao
2025-04-02 14:11 ` David Ahern
2025-04-02 16:01 ` Steven Rostedt
2025-04-03 11:38 ` Breno Leitao
2025-02-26 22:46 ` Jason Xing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250224-tcpsendmsg-v1-1-bac043c59cc8@debian.org \
--to=leitao@debian.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rostedt@goodmis.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).