From: Peter Zijlstra <peterz@infradead.org>
To: Menglong Dong <menglong8.dong@gmail.com>
Cc: rostedt@goodmis.org, mark.rutland@arm.com,
alexei.starovoitov@gmail.com, catalin.marinas@arm.com,
will@kernel.org, mhiramat@kernel.org, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
x86@kernel.org, hpa@zytor.com, mathieu.desnoyers@efficios.com,
nathan@kernel.org, ndesaulniers@google.com, morbo@google.com,
justinstitt@google.com, dongml2@chinatelecom.cn,
akpm@linux-foundation.org, rppt@kernel.org, graf@amazon.com,
dan.j.williams@intel.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
bpf@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH bpf-next v2] add function metadata support
Date: Thu, 27 Feb 2025 17:53:02 +0100 [thread overview]
Message-ID: <20250227165302.GB5880@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20250226121537.752241-1-dongml2@chinatelecom.cn>
On Wed, Feb 26, 2025 at 08:15:37PM +0800, Menglong Dong wrote:
> In x86, we need 5-bytes to prepend a "mov %eax xxx" insn, which can hold
> a 4-bytes index. So we have following logic:
>
> 1. use the head 5-bytes if CFI_CLANG is not enabled
> 2. use the tail 5-bytes if MITIGATION_CALL_DEPTH_TRACKING is not enabled
> 3. compile the kernel with extra 5-bytes padding if
> MITIGATION_CALL_DEPTH_TRACKING and CFI_CLANG are both enabled.
3) would result in 16+5 bytes padding, what does that do for alignment?
Functions should be 16 byte aligned.
Also, did you make sure all the code in arch/x86/kernel/alternative.c
still works? Because adding extra padding in the CFI_CLANG case moves
where the CFI bytes are emitted and all the CFI rewriting code goes
sideways.
next prev parent reply other threads:[~2025-02-27 16:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 12:15 [PATCH bpf-next v2] add function metadata support Menglong Dong
2025-02-27 15:18 ` kernel test robot
2025-02-27 16:32 ` kernel test robot
2025-02-27 16:53 ` Peter Zijlstra [this message]
2025-02-28 9:53 ` Menglong Dong
2025-02-28 10:26 ` Peter Zijlstra
2025-02-28 10:29 ` Peter Zijlstra
2025-02-28 13:01 ` Menglong Dong
2025-02-27 17:48 ` kernel test robot
2025-02-28 0:43 ` kernel test robot
2025-03-04 6:25 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250227165302.GB5880@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=alexei.starovoitov@gmail.com \
--cc=bp@alien8.de \
--cc=bpf@vger.kernel.org \
--cc=catalin.marinas@arm.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dongml2@chinatelecom.cn \
--cc=graf@amazon.com \
--cc=hpa@zytor.com \
--cc=justinstitt@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=menglong8.dong@gmail.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=rostedt@goodmis.org \
--cc=rppt@kernel.org \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).